Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 12159003: Merge 141195 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
===================================================================
--- Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (revision 141524)
+++ Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (working copy)
@@ -195,14 +195,10 @@
void BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree()
{
- DEFINE_STATIC_LOCAL(AtomicString, dateAndTimeInputContainerPseudoId, ("-webkit-date-and-time-container", AtomicString::ConstructFromLiteral));
-
ASSERT(element()->shadow());
Document* document = element()->document();
- RefPtr<HTMLDivElement> container = HTMLDivElement::create(document);
- element()->userAgentShadowRoot()->appendChild(container);
- container->setPseudo(dateAndTimeInputContainerPseudoId);
+ ContainerNode* container = element()->userAgentShadowRoot();
RefPtr<DateTimeEditElement> dateTimeEditElement(DateTimeEditElement::create(document, *this));
m_dateTimeEditElement = dateTimeEditElement.get();
@@ -350,6 +346,11 @@
}
}
+bool BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection() const
+{
+ return true;
+}
+
bool BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod() const
{
return false;
@@ -365,10 +366,6 @@
if (!m_dateTimeEditElement)
return;
- AtomicString direction = element()->locale().isRTL() ? AtomicString("rtl", AtomicString::ConstructFromLiteral) : AtomicString("ltr", AtomicString::ConstructFromLiteral);
- if (Element* container = ElementTraversal::firstWithin(element()->userAgentShadowRoot()))
- container->setAttribute(HTMLNames::dirAttr, direction);
-
DateTimeEditElement::LayoutParameters layoutParameters(element()->locale(), createStepRange(AnyIsDefaultStep));
DateComponents date;
« no previous file with comments | « Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h ('k') | Source/WebCore/html/HTMLInputElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698