Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: sky/sdk/lib/widgets/basic.dart

Issue 1215893002: Set the default text color to white (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/basic.dart
diff --git a/sky/sdk/lib/widgets/basic.dart b/sky/sdk/lib/widgets/basic.dart
index 7c9f8d4533f04dec13f53883eb069bbcb2ea4fb2..f51f9ab60220909a0a14c3f0ba5577b2e042c39e 100644
--- a/sky/sdk/lib/widgets/basic.dart
+++ b/sky/sdk/lib/widgets/basic.dart
@@ -439,8 +439,9 @@ class Text extends Component {
} else {
combinedStyle = style;
}
- if (combinedStyle != null)
- text = new InlineStyle(combinedStyle, [text]);
+ if (combinedStyle == null)
+ combinedStyle = const TextStyle(color: const Color(0xFFFFFFFF));
abarth-chromium 2015/06/27 00:31:51 Maybe we should use a TextStyle from typography.da
+ text = new InlineStyle(combinedStyle, [text]);
return new Inline(text: text);
abarth-chromium 2015/06/27 00:31:51 IMHO, we should merge lines 444 and 445 so we don'
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698