Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215893002: Set the default text color to white (Closed)

Created:
5 years, 6 months ago by iansf
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Find the actual default color and change it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/engine/core/rendering/style/RenderStyle.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
iansf
Not sure if this is how default styling should work...
5 years, 6 months ago (2015-06-26 23:57:22 UTC) #1
abarth-chromium
Do we need to update any of our other examples? https://codereview.chromium.org/1215893002/diff/1/sky/sdk/lib/widgets/basic.dart File sky/sdk/lib/widgets/basic.dart (right): https://codereview.chromium.org/1215893002/diff/1/sky/sdk/lib/widgets/basic.dart#newcode443 ...
5 years, 6 months ago (2015-06-27 00:31:51 UTC) #2
abarth-chromium
LGTM
5 years, 6 months ago (2015-06-27 00:31:59 UTC) #3
Hixie
I think we should make this change at the C++ level. Change the default color ...
5 years, 5 months ago (2015-06-29 16:03:57 UTC) #4
iansf
New version
5 years, 5 months ago (2015-06-29 20:08:09 UTC) #5
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-29 20:11:56 UTC) #6
iansf
5 years, 5 months ago (2015-06-29 20:33:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bcbe74d3b639939884b4e40e385c84eb3a56ed11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698