Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 1215823003: Remove old NeedsRebaseline entries (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove old NeedsRebaseline entries BUG=313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198097

Patch Set 1 #

Patch Set 2 : Try to rebaseline #

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -105 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/relative-sized-use-on-symbol-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/custom/relative-sized-use-on-symbol-expected.txt View 1 2 chunks +10 lines, -7 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt View 1 1 chunk +31 lines, -25 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt View 1 1 chunk +31 lines, -25 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/relative-sized-use-on-symbol-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt View 1 1 chunk +31 lines, -22 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt View 1 1 chunk +31 lines, -22 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
rwlbuis
PTAL. I guess these entries were not really needed after all since for example platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt ...
5 years, 6 months ago (2015-06-26 20:35:33 UTC) #2
pdr.
LGTM but I've removed NOTRY=true to send this through the CQ just in case.
5 years, 6 months ago (2015-06-26 20:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215823003/1
5 years, 6 months ago (2015-06-26 20:40:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60971)
5 years, 6 months ago (2015-06-26 21:51:09 UTC) #7
rwlbuis
On 2015/06/26 21:51:09, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-26 22:02:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215823003/40001
5 years, 5 months ago (2015-06-30 15:48:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68826)
5 years, 5 months ago (2015-06-30 19:27:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215823003/40001
5 years, 5 months ago (2015-06-30 19:29:07 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 20:42:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198097

Powered by Google App Engine
This is Rietveld 408576698