Source/bindings/core/v8/ScriptValue.h - Issue 1215813003: Correctly track lifetime of promise rejection events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptValue.h

Issue 1215813003: Correctly track lifetime of promise rejection events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptValue.h

diff --git a/Source/bindings/core/v8/ScriptValue.h b/Source/bindings/core/v8/ScriptValue.h

index 010f92d62aa854f28ad1adb0efe2c4be63d40840..b06e12920432a439fee64a90d1ceab8e57198550 100644

--- a/Source/bindings/core/v8/ScriptValue.h

+++ b/Source/bindings/core/v8/ScriptValue.h

@@ -179,6 +179,11 @@ public:

bool toString(String&) const;

+ void setReference(const v8::Persistent<v8::Object>& parent, v8::Isolate* isolate)

+ {

+ m_value->setReference(parent, isolate);

+ }

static ScriptValue createNull(ScriptState*);

private: