Correctly track lifetime of promise rejection events

Correctly track lifetime of promise rejection events

BUG=495801
R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198042

[haraken, 2015-06-29 07:26:54]

Can we have a test?

(I guess we can generalize the mechanism to something like WeakScriptValue and
use it in other Events as well.)

https://codereview.chromium.org/1215813003/diff/1/Source/core/events/PromiseR...
File Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/1215813003/diff/1/Source/core/events/PromiseR...
Source/core/events/PromiseRejectionEvent.cpp:54: m_promise.setReference(wrapper,
isolate);

This reference can be a cross-world reference. Would you add a comment on why it
is ok here?

[jochen (gone - plz use gerrit), 2015-06-29 07:43:53]

done, ptal

[haraken, 2015-06-29 08:29:31]

LGTM

[jochen (gone - plz use gerrit), 2015-06-29 09:18:56]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-06-29 09:19:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215813003/50001

[commit-bot: I haz the power, 2015-06-29 09:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 09:22:34]

Failed to apply patch for Source/core/events/PromiseRejectionEvent.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/events/PromiseRejectionEvent.h
  Hunk #1 FAILED at 5.
  Hunk #2 succeeded at 31 with fuzz 1 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/events/PromiseRejectionEvent.h.rej

Patch:       Source/core/events/PromiseRejectionEvent.h
Index: Source/core/events/PromiseRejectionEvent.h
diff --git a/Source/core/events/PromiseRejectionEvent.h
b/Source/core/events/PromiseRejectionEvent.h
index
c71f5dbe04b5598b4aa51faad2fd551469712fb3..2f9c68c431ad2c1c80fc47680877e67ff1cea609
100644
--- a/Source/core/events/PromiseRejectionEvent.h
+++ b/Source/core/events/PromiseRejectionEvent.h
@@ -5,6 +5,7 @@
 #ifndef PromiseRejectionEvent_h
 #define PromiseRejectionEvent_h
 
+#include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptState.h"
@@ -30,6 +31,8 @@ public:
     ScriptValue reason(ScriptState*) const;
     ScriptPromise promise(ScriptState*) const;
 
+    void setWrapperReference(v8::Isolate*, const v8::Persistent<v8::Object>&);
+
     virtual const AtomicString& interfaceName() const override;
 
     DECLARE_VIRTUAL_TRACE();

[commit-bot: I haz the power, 2015-06-29 09:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[jochen (gone - plz use gerrit), 2015-06-30 07:46:40]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-06-30 07:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1215813003/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-30 07:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215813003/70001

[commit-bot: I haz the power, 2015-06-30 09:08:50]

Committed patchset #5 (id:70001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198042