left + right mouse button causes dart exception

left + right mouse button causes dart exception

We should remove the state from our map only if the last button is going up.

Fixes #260

R=chinmaygarde@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/1a3dfeae5603bb18fe698c8fd3ca5c03460d8dae

[Chinmay, 2015-07-06 16:51:01]

chinmaygarde@google.com changed reviewers:
+ chinmaygarde@google.com

[Chinmay, 2015-07-06 16:51:02]

lgtm. Does dart have a counted set?

[abarth-chromium, 2015-07-06 16:54:17]

On 2015/07/06 at 16:51:02, chinmaygarde wrote:
> lgtm. Does dart have a counted set?

I don't see anything obvious:

https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:collection

However, we could keep a count in the state object.  You're saying we should
count up the downs and match them with the ups?

[Chinmay, 2015-07-06 17:02:04]

On 2015/07/06 at 16:54:17, abarth wrote:
> On 2015/07/06 at 16:51:02, chinmaygarde wrote:
> > lgtm. Does dart have a counted set?
> 
> I don't see anything obvious:
> 
>
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:collection
> 
> However, we could keep a count in the state object.  You're saying we should
count up the downs and match them with the ups?

I was wondering if there was a way to query the state object for the buttons
down at any given moment. I suppose it is not of too much utility now. But may
be useful information for custom gesture recognizers. Just a nit in any case.

[abarth-chromium, 2015-07-06 17:43:32]

On 2015/07/06 at 17:02:04, chinmaygarde wrote:
> I was wondering if there was a way to query the state object for the buttons
down at any given moment. I suppose it is not of too much utility now. But may
be useful information for custom gesture recognizers. Just a nit in any case.

Yeah, we can add that when we need to for gesture recognizers.

[abarth-chromium, 2015-07-06 17:44:14]

Committed patchset #1 (id:1) manually as
1a3dfeae5603bb18fe698c8fd3ca5c03460d8dae (presubmit successful).