Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1215743002: Convert ui_base_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Alexander Potapenko
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_midi_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ui_base_unittests to run exclusively on Swarming 8 configs already ran on Swarming 21 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert ui_base_unittests Removed 'ui_unittests Framework.framework.dSYM/'. It is not created, it is suspected it is because it contains only data, not code. R=dpranke@chromium.org TBR= BUG=98637 Committed: https://crrev.com/173899ed5de35632983b7c5e5b8be8c2d24a90e7 Cr-Commit-Position: refs/heads/master@{#336664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download
M ui/base/ui_base_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
M-A Ruel
This is a redo of https://codereview.chromium.org/1206413002/ which was reverted in https://codereview.chromium.org/1210183005/. After discussion with Alexander, ...
5 years, 6 months ago (2015-06-26 14:46:58 UTC) #1
Dirk Pranke
lgtm
5 years, 5 months ago (2015-06-29 19:36:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215743002/1
5 years, 5 months ago (2015-06-29 20:09:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/74728)
5 years, 5 months ago (2015-06-29 20:18:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215743002/1
5 years, 5 months ago (2015-06-29 22:33:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 22:39:00 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 22:40:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/173899ed5de35632983b7c5e5b8be8c2d24a90e7
Cr-Commit-Position: refs/heads/master@{#336664}

Powered by Google App Engine
This is Rietveld 408576698