Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Issue 1215713021: Reverted the code for the non-interactive audible tab notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notification
Patch Set: Rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
index 4f7869e8622462011d760637faa087bb43ae4f08..17880d15d5d9b7a6a028509fd3825c15895e9f4b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
@@ -45,7 +45,7 @@ import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;
import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.OverrideUrlLoadingResult;
import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;
import org.chromium.chrome.browser.fullscreen.FullscreenManager;
-import org.chromium.chrome.browser.media.MediaNotificationService;
+import org.chromium.chrome.browser.media.MediaCaptureNotificationService;
import org.chromium.chrome.browser.media.ui.MediaSessionTabHelper;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
import org.chromium.chrome.browser.ntp.NativePageAssassin;
@@ -447,9 +447,9 @@ public class ChromeTab extends Tab {
@Override
public void navigationStateChanged(int flags) {
if ((flags & InvalidateTypes.TAB) != 0) {
- MediaNotificationService.updateMediaNotificationForTab(
+ MediaCaptureNotificationService.updateMediaNotificationForTab(
getApplicationContext(), getId(), isCapturingAudio(),
- isCapturingVideo(), false, getUrl());
+ isCapturingVideo(), getUrl());
}
super.navigationStateChanged(flags);
}
@@ -552,14 +552,6 @@ public class ChromeTab extends Tab {
return !isClosing()
&& ChromeWebContentsDelegateAndroid.nativeIsCapturingVideo(getWebContents());
}
-
- /**
- * @return Whether audio is being played.
- */
- private boolean hasAudibleAudio() {
- return !isClosing()
- && ChromeWebContentsDelegateAndroid.nativeHasAudibleAudio(getWebContents());
- }
}
/**
@@ -883,8 +875,8 @@ public class ChromeTab extends Tab {
@Override
public void destroy() {
- MediaNotificationService.updateMediaNotificationForTab(
- getApplicationContext(), getId(), false, false, false, getUrl());
+ MediaCaptureNotificationService.updateMediaNotificationForTab(
+ getApplicationContext(), getId(), false, false, getUrl());
super.destroy();
}
};

Powered by Google App Engine
This is Rietveld 408576698