Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1215713009: Scrollable TabBar Version 1 - support for flinging (Closed)

Created:
5 years, 5 months ago by hansmuller1
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Scrollable TabBar Version 1 - support for flinging As far as I can tell, Material TabBars are not supposed to overscroll/bounce. The new TabBarScrollBehavior class supports fling, but it doesn't overscroll/bounce. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e00084df3b842a8b257c7c863598cf73ee385338

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M sky/sdk/lib/widgets/tabs.dart View 5 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hansmuller
PTAL
5 years, 5 months ago (2015-07-06 20:30:36 UTC) #5
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-06 20:32:00 UTC) #6
hansmuller1
5 years, 5 months ago (2015-07-06 20:52:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
e00084df3b842a8b257c7c863598cf73ee385338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698