Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1215703010: Move home.dart into example/demo_launcher (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move home.dart into example/demo_launcher This CL makes home.dart less of a special snowflake and instead makes it a peer to the other Sky examples. As a result, we can add a sky.yaml file and embed the thumbnail assets it needs into demo_launcher.skyx. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e4d059ed61c4815c6a836f0cfd46059d6f98fbd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -214 lines) Patch
M sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/example/demo_launcher/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download
A + sky/sdk/example/demo_launcher/assets/game_thumbnail.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/assets/sector_thumbnail.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/assets/stocks_thumbnail.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/lib/main.dart View 2 chunks +9 lines, -14 lines 0 comments Download
A sky/sdk/example/demo_launcher/sky.yaml View 1 chunk +4 lines, -0 lines 0 comments Download
D sky/sdk/example/game/res/thumbnail.png View Binary file 0 comments Download
D sky/sdk/example/stocks/thumbnail.png View Binary file 0 comments Download
D sky/sdk/example/widgets/sector_thumbnail.png View Binary file 0 comments Download
D sky/sdk/home.dart View 1 chunk +0 lines, -189 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/TracingController.java View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/skyx/bin/skyx.dart View 4 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 5 months ago (2015-07-06 21:38:38 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-06 21:47:08 UTC) #4
eseidel
lgtm
5 years, 5 months ago (2015-07-06 21:47:08 UTC) #5
abarth-chromium
5 years, 5 months ago (2015-07-06 21:49:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4d059ed61c4815c6a836f0cfd46059d6f98fbd4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698