Recipe for running AndroidWebViewShell instrumentation layout tests.

Recipe for running AndroidWebViewShell instrumentation layout tests.

This recipe is intended to run on the Android WebView L (dbg) bot.
It runs the instrumentation tests inside the AndroidWebViewShell.apk.

BUG=504418
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295913

[timvolodine, 2015-06-26 15:53:29]

timvolodine@chromium.org changed reviewers:
+ navabi@chromium.org, torne@chromium.org

[Torne, 2015-06-29 12:52:41]

generally lgtm but don't know a lot about recipes.

[timvolodine, 2015-06-29 17:02:11]

On 2015/06/29 12:52:41, Torne wrote:
> generally lgtm but don't know a lot about recipes.

Armand does this recipe look ok to you?

[timvolodine, 2015-06-30 17:57:20]

On 2015/06/29 17:02:11, timvolodine wrote:
> On 2015/06/29 12:52:41, Torne wrote:
> > generally lgtm but don't know a lot about recipes.
> 
> Armand does this recipe look ok to you?

Now that WebViewLayoutTest (https://codereview.chromium.org/1215733002/) does
it's own copying and the transfer of blink files is handled by the .isolate this
recipe can be simplified. I've uploaded a new recipe-patch with the copying
hocus pocus removed.

[navabi, 2015-06-30 18:08:55]

navabi@google.com changed reviewers:
+ luqui@chromium.org, navabi@google.com

[navabi, 2015-06-30 18:08:56]

The change looks good, but it looks like you did not run simulation tests. This
will create an expectation file showing all the steps that the recipe will
perform. Specifically, I would expect recipe changes that shows that the layout
tests are run.

To run cd into build/scripts/slave/unittests/ and run:
python recipe_simulation_tests.py train

I am going on vacation for these next two weeks, so I'm adding luqui@. He is the
Android recipe expert and he can help review recipe changes in the meantime.

[luqui, 2015-06-30 18:26:58]

https://codereview.chromium.org/1215703004/diff/20001/scripts/slave/recipes/a...
File scripts/slave/recipes/android_webview_shell_tests.py (right):

https://codereview.chromium.org/1215703004/diff/20001/scripts/slave/recipes/a...
scripts/slave/recipes/android_webview_shell_tests.py:92: droid =
api.m.chromium_android
just api.chromium_android.  m is what recipe modules use to refer to their
dependencies.

[timvolodine, 2015-07-01 15:23:53]

thanks for the comments, I've updated the expectations file.
luqui@ could you take another look please?

https://codereview.chromium.org/1215703004/diff/20001/scripts/slave/recipes/a...
File scripts/slave/recipes/android_webview_shell_tests.py (right):

https://codereview.chromium.org/1215703004/diff/20001/scripts/slave/recipes/a...
scripts/slave/recipes/android_webview_shell_tests.py:92: droid =
api.m.chromium_android
On 2015/06/30 18:26:58, luqui wrote:
> just api.chromium_android.  m is what recipe modules use to refer to their
> dependencies.

Done.

[luqui, 2015-07-01 17:51:15]

lgtm

[timvolodine, 2015-07-02 12:31:08]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2015-07-02 12:31:08]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1215703004/#ps40001
(title: "fix comment + update expectations")

[commit-bot: I haz the power, 2015-07-02 12:31:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215703004/40001

[timvolodine, 2015-07-02 12:33:11]

The CQ bit was unchecked by timvolodine@chromium.org

[timvolodine, 2015-07-02 12:40:06]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2015-07-02 12:40:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215703004/40001

[commit-bot: I haz the power, 2015-07-02 12:43:58]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295913