Adding YUVA support for enabling Alpha Playback

cc/output/renderer_pixeltest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "cc/layers/append_quads_data.h"
 #include "cc/output/gl_renderer.h"
 #include "cc/quads/draw_quad.h"
 #include "cc/quads/picture_draw_quad.h"
 #include "cc/resources/platform_color.h"
@@ skipping 189 matching lines @@
   pass_list.push_back(child_pass.Pass());
   pass_list.push_back(root_pass.Pass());
 
   EXPECT_TRUE(this->RunPixelTestWithReadbackTarget(
       &pass_list,
       child_pass_ptr,
       base::FilePath(FILE_PATH_LITERAL("green_small.png")),
       ExactPixelComparator(true)));
 }
 
+TEST_F(GLRendererPixelTest, SimpleYUVRect) {
+  gfx::Rect rect(this->device_viewport_size_);
+  gfx::Rect opaque_rect(0, 0, 0, 0);
+
+  RenderPass::Id id(1, 1);
+  scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
+
+  scoped_ptr<SharedQuadState> shared_state =
+      CreateTestSharedQuadState(gfx::Transform(), rect);
+
+  ResourceProvider::ResourceId y_resource =
+      cc::PixelTest::resource_provider_->CreateResource(

[enne (OOO), 2013/05/30 23:52:54]

cc::PixelTest::resource_provider_ => this->resource_provider_?

[vignesh, 2013/05/31 19:49:37]

Done.

+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+  ResourceProvider::ResourceId u_resource =
+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+  ResourceProvider::ResourceId v_resource =
+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+
+  int w = this->device_viewport_size_.width();
+  int h = this->device_viewport_size_.height();
+  uint8_t* y_plane = new uint8_t[w * h];

[enne (OOO), 2013/05/30 23:52:54]

Please use a scoped_ptr for any memory ownership:

    scoped_ptr<uint8_t[]> y_plane(new uint8_t[w * h]);

[vignesh, 2013/05/31 19:49:37]

Done.

+  uint8_t* u_plane = new uint8_t[(w / 2) * (h / 2)];

[enne (OOO), 2013/05/30 23:52:54]

Can you put this repeated expression in a temporary constant, like y_plane_size
and uv_plane_size?

[vignesh, 2013/05/31 19:49:37]

Done.

+  uint8_t* v_plane = new uint8_t[(w / 2) * (h / 2)];
+  // YUV values representing Green.
+  memset(y_plane, 149, w * h);
+  memset(u_plane, 43, (w / 2) * (h / 2));
+  memset(v_plane, 21, (w / 2) * (h / 2));
+
+  cc::PixelTest::resource_provider_->SetPixels(y_resource, y_plane, rect, rect,
+                                               gfx::Vector2d());
+  cc::PixelTest::resource_provider_->SetPixels(u_resource, u_plane, rect, rect,
+                                               gfx::Vector2d());
+  cc::PixelTest::resource_provider_->SetPixels(v_resource, v_plane, rect, rect,
+                                               gfx::Vector2d());
+
+  scoped_ptr<cc::YUVVideoDrawQuad> yuv_quad = cc::YUVVideoDrawQuad::Create();
+  yuv_quad->SetNew(shared_state.get(), rect, opaque_rect, gfx::Size(0, 0),

[enne (OOO), 2013/05/30 23:52:54]

style nit: gfx::Size(), here and elsewhere

[vignesh, 2013/05/31 19:49:37]

Done.

+                   y_resource, u_resource, v_resource, 0);
+
+  pass->quad_list.push_back(yuv_quad.PassAs<DrawQuad>());
+
+  RenderPassList pass_list;
+  pass_list.push_back(pass.Pass());
+
+  delete[] y_plane;
+  delete[] u_plane;
+  delete[] v_plane;
+
+  EXPECT_TRUE(this->RunPixelTest(
+      &pass_list,
+      base::FilePath(FILE_PATH_LITERAL("green.png")),
+      ExactPixelComparator(true)));
+}
+
+TEST_F(GLRendererPixelTest, SimpleYUVARect) {
+  gfx::Rect rect(this->device_viewport_size_);
+  gfx::Rect opaque_rect(0, 0, 0, 0);
+
+  RenderPass::Id id(1, 1);
+  scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
+
+  scoped_ptr<SharedQuadState> shared_state =
+      CreateTestSharedQuadState(gfx::Transform(), rect);
+
+  ResourceProvider::ResourceId y_resource =

[enne (OOO), 2013/05/30 23:52:54]

There's a lot of repeated code between these two tests.  What about a helper
VideoGLRendererPixelTest class that could do a lot of this repeated setup in one
place?

[vignesh, 2013/05/31 19:49:37]

Done.

+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+  ResourceProvider::ResourceId u_resource =
+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+  ResourceProvider::ResourceId v_resource =
+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+  ResourceProvider::ResourceId a_resource =
+      cc::PixelTest::resource_provider_->CreateResource(
+          this->device_viewport_size_,
+          GL_RGBA,
+          ResourceProvider::TextureUsageAny);
+
+  int w = this->device_viewport_size_.width();
+  int h = this->device_viewport_size_.height();
+  uint8_t* y_plane = new uint8_t[w * h];
+  uint8_t* u_plane = new uint8_t[(w / 2) * (h / 2)];
+  uint8_t* v_plane = new uint8_t[(w / 2) * (h / 2)];
+  uint8_t* a_plane = new uint8_t[w * h];
+  // YUV values representing Green.
+  memset(y_plane, 149, w * h);
+  memset(u_plane, 43, (w / 2) * (h / 2));
+  memset(v_plane, 21, (w / 2) * (h / 2));
+  memset(a_plane, 128, (w / 2) * (h / 2));
+
+  cc::PixelTest::resource_provider_->SetPixels(y_resource, y_plane, rect, rect,
+                                               gfx::Vector2d());
+  cc::PixelTest::resource_provider_->SetPixels(u_resource, u_plane, rect, rect,
+                                               gfx::Vector2d());
+  cc::PixelTest::resource_provider_->SetPixels(v_resource, v_plane, rect, rect,
+                                               gfx::Vector2d());
+  cc::PixelTest::resource_provider_->SetPixels(a_resource, a_plane, rect, rect,
+                                               gfx::Vector2d());
+
+  scoped_ptr<cc::YUVVideoDrawQuad> yuv_quad = cc::YUVVideoDrawQuad::Create();
+  yuv_quad->SetNew(shared_state.get(), rect, opaque_rect, gfx::Size(0, 0),
+                   y_resource, u_resource, v_resource, a_resource);
+
+  pass->quad_list.push_back(yuv_quad.PassAs<DrawQuad>());
+
+  scoped_ptr<SolidColorDrawQuad> color_quad = SolidColorDrawQuad::Create();
+  color_quad->SetNew(shared_state.get(), rect, SK_ColorWHITE, false);
+
+  pass->quad_list.push_back(color_quad.PassAs<DrawQuad>());
+
+  RenderPassList pass_list;
+  pass_list.push_back(pass.Pass());
+
+  delete[] y_plane;
+  delete[] u_plane;
+  delete[] v_plane;
+  delete[] a_plane;
+
+  EXPECT_TRUE(this->RunPixelTest(
+      &pass_list,
+      base::FilePath(FILE_PATH_LITERAL("green_alpha.png")),
+      ExactPixelComparator(true)));
+}
+
 TYPED_TEST(RendererPixelTest, FastPassColorFilterAlpha) {
   gfx::Rect viewport_rect(this->device_viewport_size_);
 
   RenderPass::Id root_pass_id(1, 1);
   scoped_ptr<RenderPass> root_pass =
       CreateTestRootRenderPass(root_pass_id, viewport_rect);
 
   RenderPass::Id child_pass_id(2, 2);
   gfx::Rect pass_rect(this->device_viewport_size_);
   gfx::Transform transform_to_root;
@@ skipping 753 matching lines @@
 
   EXPECT_TRUE(this->RunPixelTest(
       &pass_list,
       base::FilePath(FILE_PATH_LITERAL("four_blue_green_checkers.png")),
       ExactPixelComparator(true)));
 }
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace
 }  // namespace cc