Adding YUVA support for enabling Alpha Playback

cc/quads/yuv_video_draw_quad.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/quads/yuv_video_draw_quad.h"
 
 #include "base/logging.h"
 
 namespace cc {
 
 YUVVideoDrawQuad::YUVVideoDrawQuad() {}
 YUVVideoDrawQuad::~YUVVideoDrawQuad() {}
 
 scoped_ptr<YUVVideoDrawQuad> YUVVideoDrawQuad::Create() {
   return make_scoped_ptr(new YUVVideoDrawQuad);
 }
 
 void YUVVideoDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
-                              gfx::Rect rect,
-                              gfx::Rect opaque_rect,
-                              gfx::SizeF tex_scale,
-                              const VideoLayerImpl::FramePlane& y_plane,
-                              const VideoLayerImpl::FramePlane& u_plane,
-                              const VideoLayerImpl::FramePlane& v_plane) {
+                               gfx::Rect rect,
+                               gfx::Rect opaque_rect,
+                               gfx::SizeF tex_scale,
+                               const VideoLayerImpl::FramePlane* y_plane,
+                               const VideoLayerImpl::FramePlane* u_plane,
+                               const VideoLayerImpl::FramePlane* v_plane,
+                               const VideoLayerImpl::FramePlane* a_plane) {
   gfx::Rect visible_rect = rect;
-  bool needs_blending = false;
-  DrawQuad::SetAll(shared_quad_state, DrawQuad::YUV_VIDEO_CONTENT, rect,
-                   opaque_rect, visible_rect, needs_blending);
-  this->tex_scale = tex_scale;
-  this->y_plane = y_plane;
-  this->u_plane = u_plane;
-  this->v_plane = v_plane;
+  bool needs_blending = !!a_plane;

[danakj, 2013/04/07 19:08:46]

Actually, I think you can just leave this false still.

Take a look at the opaque_rect given to this function. It's an empty rect if the
layer doesn't have contents_opaque() set to true on it. The video system
shouldn't be setting contents_opaque() true if the alpha plane isn't opaque, so
you should get the right behaviour from the compositor if the video system is
setting the opaque-ness on the video layer correctly.

The needs_blending=true flag is really just there to override and turn on
blending even though the contents are opaque.

[vignesh, 2013/04/09 20:48:03]

Done.

+  SetAll(shared_quad_state, rect, opaque_rect, visible_rect, needs_blending,
+         tex_scale, y_plane, u_plane, v_plane, a_plane);
 }
 
 void YUVVideoDrawQuad::SetAll(const SharedQuadState* shared_quad_state,
                               gfx::Rect rect,
                               gfx::Rect opaque_rect,
                               gfx::Rect visible_rect,
                               bool needs_blending,
                               gfx::SizeF tex_scale,
-                              const VideoLayerImpl::FramePlane& y_plane,
-                              const VideoLayerImpl::FramePlane& u_plane,
-                              const VideoLayerImpl::FramePlane& v_plane) {
+                              const VideoLayerImpl::FramePlane* y_plane,
+                              const VideoLayerImpl::FramePlane* u_plane,
+                              const VideoLayerImpl::FramePlane* v_plane,
+                              const VideoLayerImpl::FramePlane* a_plane) {
   DrawQuad::SetAll(shared_quad_state, DrawQuad::YUV_VIDEO_CONTENT, rect,
                    opaque_rect, visible_rect, needs_blending);
   this->tex_scale = tex_scale;
-  this->y_plane = y_plane;
-  this->u_plane = u_plane;
-  this->v_plane = v_plane;
+  this->y_plane = *y_plane;
+  this->u_plane = *u_plane;
+  this->v_plane = *v_plane;
+  if (a_plane)
+    this->a_plane = *a_plane;
 }
 
 void YUVVideoDrawQuad::IterateResources(
     const ResourceIteratorCallback& callback) {
   y_plane.resource_id = callback.Run(y_plane.resource_id);
   u_plane.resource_id = callback.Run(u_plane.resource_id);
   v_plane.resource_id = callback.Run(v_plane.resource_id);
+  if (a_plane.resource_id)
+    a_plane.resource_id = callback.Run(a_plane.resource_id);
 }
 
 const YUVVideoDrawQuad* YUVVideoDrawQuad::MaterialCast(
     const DrawQuad* quad) {
   DCHECK(quad->material == DrawQuad::YUV_VIDEO_CONTENT);
   return static_cast<const YUVVideoDrawQuad*>(quad);
 }
 
 }  // namespace cc