Adding YUVA support for enabling Alpha Playback

cc/yuva_video_draw_quad.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CC_YUV_VIDEO_DRAW_QUAD_H_
-#define CC_YUV_VIDEO_DRAW_QUAD_H_
+#ifndef CC_YUVA_VIDEO_DRAW_QUAD_H_
+#define CC_YUVA_VIDEO_DRAW_QUAD_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "cc/cc_export.h"
 #include "cc/draw_quad.h"
 #include "cc/video_layer_impl.h"
 
 namespace cc {
 
-class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {
+class CC_EXPORT YUVAVideoDrawQuad : public DrawQuad {
  public:
-  virtual ~YUVVideoDrawQuad();
+  virtual ~YUVAVideoDrawQuad();
 
-  static scoped_ptr<YUVVideoDrawQuad> Create();
+  static scoped_ptr<YUVAVideoDrawQuad> Create();
 
   void SetNew(const SharedQuadState* shared_quad_state,
               gfx::Rect rect,
               gfx::Rect opaque_rect,
               gfx::SizeF tex_scale,
               const VideoLayerImpl::FramePlane& y_plane,
               const VideoLayerImpl::FramePlane& u_plane,
-              const VideoLayerImpl::FramePlane& v_plane);
+              const VideoLayerImpl::FramePlane& v_plane,
+              const VideoLayerImpl::FramePlane& a_plane);
 
   void SetAll(const SharedQuadState* shared_quad_state,
               gfx::Rect rect,
               gfx::Rect opaque_rect,
               gfx::Rect visible_rect,
               bool needs_blending,
               gfx::SizeF tex_scale,
               const VideoLayerImpl::FramePlane& y_plane,
               const VideoLayerImpl::FramePlane& u_plane,
-              const VideoLayerImpl::FramePlane& v_plane);
+              const VideoLayerImpl::FramePlane& v_plane,
+              const VideoLayerImpl::FramePlane& a_plane);
 
   gfx::SizeF tex_scale;
   VideoLayerImpl::FramePlane y_plane;
   VideoLayerImpl::FramePlane u_plane;
   VideoLayerImpl::FramePlane v_plane;
+  VideoLayerImpl::FramePlane a_plane;

[danakj, 2013/02/12 00:53:26]

Can you just add this plane to the YUVDrawQuad class and a flag to say if it's
being used?

[vignesh, 2013/02/12 01:13:50]

Can i extend this class from YUVVideoDrawQuad instead of adding a flag to track
its usage. I feel that's a little cleaner than adding a flag and adding if
checks in almost every function of the class.

[danakj, 2013/02/12 01:18:09]

Why do you need so many ifs? The FramePlane is a pretty simple struct, it could
just contain 0's if it's unusued. Maybe you don't even need a bool (thought it
might be nice for the GLRenderer code though).

[vigneshv, 2013/02/15 18:05:02]

Done.

 
-  virtual void AppendResources(ResourceProvider::ResourceIdArray* resources)
-      OVERRIDE;
-
-  static const YUVVideoDrawQuad* MaterialCast(const DrawQuad*);
+  static const YUVAVideoDrawQuad* MaterialCast(const DrawQuad*);
  private:
-  YUVVideoDrawQuad();
+  YUVAVideoDrawQuad();
 };
 
 }
 
-#endif  // CC_YUV_VIDEO_DRAW_QUAD_H_
+#endif  // CC_YUVA_VIDEO_DRAW_QUAD_H_