Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: base/android/cxa_demangle_stub.cc

Issue 1215673002: Add a stub __cxa_demangle to disable LLVM's demangler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/base.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <unistd.h>
6
7 // LLVM's demangler is large, and we have no need of it. Overriding it with
8 // our own stub version here stops a lot of code being pulled in from libc++.
9 // More here:
10 // https://llvm.org/svn/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp
11 extern "C" char* __cxa_demangle(const char* mangled_name,
12 char* buf,
13 size_t* n,
14 int* status) {
15 static const int kMemoryAllocFailure = -1; // LLVM's memory_alloc_failure.
rmcilroy 2015/06/26 12:43:49 Can we just do a CHECK(false) here instead? This w
simonb (inactive) 2015/06/26 15:00:09 I'm pretty sure we don't want to CHECK(false) here
rmcilroy 2015/06/29 09:24:18 Ok sounds good, thanks for the explanation.
16 if (status)
17 *status = kMemoryAllocFailure;
18 return nullptr;
19 }
OLDNEW
« no previous file with comments | « base/BUILD.gn ('k') | base/base.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698