Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: third_party/hunspell/hunspell.gyp

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/hunspell/BUILD.gn ('K') | « third_party/hunspell/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'hunspell', 8 'target_name': 'hunspell',
9 'type': 'static_library', 9 'type': 'static_library',
10 'msvs_guid': 'D5E8DCB2-9C61-446F-8BEE-B18CA0E0936E', 10 'msvs_guid': 'D5E8DCB2-9C61-446F-8BEE-B18CA0E0936E',
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 'USE_HUNSPELL', 63 'USE_HUNSPELL',
64 ], 64 ],
65 }, 65 },
66 'variables': { 66 'variables': {
67 'clang_warning_flags': [ 67 'clang_warning_flags': [
68 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop. 68 # affentry.cxx has one `while ((p = nextchar(p)));` parsing loop.
69 '-Wno-empty-body', 69 '-Wno-empty-body',
70 # affentry.hxx has NULL as default parameter for a FLAG in two 70 # affentry.hxx has NULL as default parameter for a FLAG in two
71 # places. 71 # places.
72 '-Wno-null-conversion', 72 '-Wno-null-conversion',
73 # hunspell has unused private fields.
74 '-Wno-unused-private-field',
73 ], 75 ],
74 }, 76 },
75 # TODO(jschuh): http://crbug.com/167187 size_t -> int 77 # TODO(jschuh): http://crbug.com/167187 size_t -> int
76 'msvs_disabled_warnings': [ 4267 ], 78 'msvs_disabled_warnings': [ 4267 ],
77 'conditions': [ 79 'conditions': [
78 ['os_posix == 1 and OS != "mac"', { 80 ['os_posix == 1 and OS != "mac"', {
79 'cflags': [ 81 'cflags': [
80 '-Wno-unused-value', 82 '-Wno-unused-value',
81 '-Wno-unused-variable', 83 '-Wno-unused-variable',
82 '-Wno-write-strings', 84 '-Wno-write-strings',
83 ], 85 ],
84 }], 86 }],
85 ['gcc_version >= 48', { 87 ['gcc_version >= 48', {
86 'cflags': [ 88 'cflags': [
87 # affentry.hxx has NULL as default parameter for a FLAG in two 89 # affentry.hxx has NULL as default parameter for a FLAG in two
88 # places. 90 # places.
89 '-Wno-conversion-null', 91 '-Wno-conversion-null',
90 ], 92 ],
91 }], 93 }],
92 ], 94 ],
93 }, 95 },
94 ], 96 ],
95 } 97 }
OLDNEW
« third_party/hunspell/BUILD.gn ('K') | « third_party/hunspell/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698