Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Side by Side Diff: third_party/cld_2/BUILD.gn

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up GN Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 6
7 gypi_values = exec_script("//build/gypi_to_gn.py", 7 gypi_values = exec_script("//build/gypi_to_gn.py",
8 [ rebase_path("cld_2.gyp") ], 8 [ rebase_path("cld_2.gyp") ],
9 "scope", 9 "scope",
10 [ "cld_2.gyp" ]) 10 [ "cld_2.gyp" ])
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 source_set("cld2_platform_impl") { 67 source_set("cld2_platform_impl") {
68 deps = [] 68 deps = []
69 if (cld2_platform_support == "static") { 69 if (cld2_platform_support == "static") {
70 deps += [ ":cld2_static" ] 70 deps += [ ":cld2_static" ]
71 } else if (cld2_platform_support == "dynamic") { 71 } else if (cld2_platform_support == "dynamic") {
72 deps += [ ":cld2_dynamic" ] 72 deps += [ ":cld2_dynamic" ]
73 } 73 }
74 } 74 }
75 75
76 config("cld2_warnings") {
77 if (is_clang) {
78 cflags = [
79 # hunspell has unused private fields.
Nico 2015/07/09 01:58:16 s/hunspell/cld_2/
benwells 2015/07/09 11:43:02 oops, done.
80 "-Wno-unused-private-field",
81 ]
82 }
83 }
84
76 static_library("cld2_static") { 85 static_library("cld2_static") {
77 sources = gypi_values.cld2_core_impl_sources 86 sources = gypi_values.cld2_core_impl_sources
78 include_dirs = [ 87 include_dirs = [
79 "src/internal", 88 "src/internal",
80 "src/public", 89 "src/public",
81 ] 90 ]
82 91
83 deps = [ 92 deps = [
84 ":cld_2", 93 ":cld_2",
85 ":cld2_data", 94 ":cld2_data",
86 ] 95 ]
87 configs -= [ "//build/config/compiler:chromium_code" ] 96 configs -= [ "//build/config/compiler:chromium_code" ]
88 configs += [ "//build/config/compiler:no_chromium_code" ] 97 configs += [
98 "//build/config/compiler:no_chromium_code",
99 ":cld2_warnings",
100 ]
89 } 101 }
90 102
91 config("cld2_dynamic_mode_config") { 103 config("cld2_dynamic_mode_config") {
92 defines = [ "CLD2_DYNAMIC_MODE" ] 104 defines = [ "CLD2_DYNAMIC_MODE" ]
93 } 105 }
94 106
95 static_library("cld2_dynamic") { 107 static_library("cld2_dynamic") {
96 sources = gypi_values.cld2_core_sources + gypi_values.cld2_core_impl_sources + 108 sources = gypi_values.cld2_core_sources + gypi_values.cld2_core_impl_sources +
97 gypi_values.cld2_dynamic_data_loader_sources 109 gypi_values.cld2_dynamic_data_loader_sources
98 include_dirs = [ 110 include_dirs = [
99 "src/internal", 111 "src/internal",
100 "src/public", 112 "src/public",
101 ] 113 ]
102 114
103 configs -= [ "//build/config/compiler:chromium_code" ] 115 configs -= [ "//build/config/compiler:chromium_code" ]
104 configs += [ 116 configs += [
105 ":cld2_dynamic_mode_config", 117 ":cld2_dynamic_mode_config",
106 "//build/config/compiler:no_chromium_code", 118 "//build/config/compiler:no_chromium_code",
119 ":cld2_warnings",
107 ] 120 ]
108 } 121 }
109 122
110 # Does not build on Windows. 123 # Does not build on Windows.
111 if (!is_win) { 124 if (!is_win) {
112 executable("cld_2_dynamic_data_tool") { 125 executable("cld_2_dynamic_data_tool") {
113 sources = [ 126 sources = [
114 "src/internal/cld2_dynamic_data_extractor.cc", 127 "src/internal/cld2_dynamic_data_extractor.cc",
115 "src/internal/cld2_dynamic_data_extractor.h", 128 "src/internal/cld2_dynamic_data_extractor.h",
116 "src/internal/cld2_dynamic_data_tool.cc", 129 "src/internal/cld2_dynamic_data_tool.cc",
117 ] 130 ]
118 131
119 include_dirs = [ 132 include_dirs = [
120 "src/internal", 133 "src/internal",
121 "src/public", 134 "src/public",
122 ] 135 ]
123 136
124 deps = [ 137 deps = [
125 ":cld2_data", 138 ":cld2_data",
126 ":cld2_dynamic", 139 ":cld2_dynamic",
127 ] 140 ]
128 141
129 configs -= [ "//build/config/compiler:chromium_code" ] 142 configs -= [ "//build/config/compiler:chromium_code" ]
130 configs += [ 143 configs += [
131 ":cld2_dynamic_mode_config", 144 ":cld2_dynamic_mode_config",
132 "//build/config/compiler:no_chromium_code", 145 "//build/config/compiler:no_chromium_code",
133 ] 146 ]
134 } 147 }
135 } 148 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698