Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1215623002: [turbofan] Add support for pushing returns into merges. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for pushing returns into merges. This will enable tail call optimization even across inlining. Plus it might enable some other interesting optimizations as well. In order to avoid blowing up the generated code, we can still canonicalize the epilogue in the CodeGenerator, similar to what fullcodegen does. R=jarin@chromium.org Committed: https://crrev.com/7337021e54d8a15183c2d4247b2ed83d9b5120ef Cr-Commit-Position: refs/heads/master@{#29311}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use NodeProperties::GetControlInput. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -10 lines) Patch
M src/compiler/common-operator-reducer.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 1 5 chunks +51 lines, -4 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-26 07:44:54 UTC) #1
Benedikt Meurer
Hey Jaro, This is a CL for danno's code stubs. Please take a look. Thanks, ...
5 years, 6 months ago (2015-06-26 07:45:32 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-26 07:52:44 UTC) #3
Jarin
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc File src/compiler/common-operator-reducer.cc (right): https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc#newcode273 src/compiler/common-operator-reducer.cc:273: value->InputAt(value->InputCount() - 1) == control && Please use NodeProperties::GetControlInput ...
5 years, 6 months ago (2015-06-26 07:55:31 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc File src/compiler/common-operator-reducer.cc (right): https://codereview.chromium.org/1215623002/diff/1/src/compiler/common-operator-reducer.cc#newcode273 src/compiler/common-operator-reducer.cc:273: value->InputAt(value->InputCount() - 1) == control && On 2015/06/26 07:55:31, ...
5 years, 6 months ago (2015-06-26 07:56:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215623002/20001
5 years, 6 months ago (2015-06-26 07:57:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 08:20:58 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 08:21:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7337021e54d8a15183c2d4247b2ed83d9b5120ef
Cr-Commit-Position: refs/heads/master@{#29311}

Powered by Google App Engine
This is Rietveld 408576698