Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 1215613002: dart2js: Fix encoding of field names in csp mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index d3b8ffbe01ab2482191425a8885c31d57afee214..552fd27b1bf63c42d822ef92512234d670d4ca74 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -1026,9 +1026,8 @@ class OldEmitter implements Emitter {
bool hasIsolateSupport = compiler.hasIsolateSupport;
jsAst.Node fieldNamesArray;
if (hasIsolateSupport) {
- fieldNamesArray = js.concatenateStrings(
- js.joinLiterals(fields, js.stringPart(",")),
- addQuotes: true);
+ fieldNamesArray =
+ new jsAst.ArrayInitializer(fields.map(js.quoteName).toList());
} else {
fieldNamesArray = new jsAst.LiteralNull();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698