Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1215583002:
[qcms] lut_inverse_interp16: fix black level inversion error (Closed)
|
Created:
5 years, 6 months ago by Noel Gordon Modified:
5 years, 6 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, Mike Lawther (Google) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[qcms] lut_inverse_interp16: fix black level inversion error
Inverting a TRC curve that is 0 at the origin should produce 0 at the
origin to avoid a black level error.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
BUG=504681
Committed: https://crrev.com/76e01b257d0d9962c5ce98087bed10f5892520ea
Cr-Commit-Position: refs/heads/master@{#336401}
Patch Set 1 #
Messages
Total messages: 24 (8 generated)
noel@chromium.org changed reviewers: + mikelawther@chromium.org
linux_android_rel_ng intermittently failing, not that Android uses qcms.
Also filed crbug.com/504703 inspector-protocol/debugger/debugger-step-into-dedicated-worker.html is a flaky crash, and uploaded a TestExpectations change to mark it so.
On 2015/06/26 05:32:33, noel gordon wrote: > Also filed crbug.com/504703 > inspector-protocol/debugger/debugger-step-into-dedicated-worker.html is a flaky > crash, and uploaded a TestExpectations change to mark it so. Flake was on Mac http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60866
Flake expectation landed https://src.chromium.org/viewvc/blink?view=rev&revision=197890
> linux_android_rel_ng intermittently failing, not that Android uses qcms. Filed https://code.google.com/p/chromium/issues/detail?id=504707 about linux_android_rel_ng perf test failure flakes.
Before this patch, the standard sRGB gamma curve inverts to: lut_inverse_interp16 invert_lut length=1024 out_length=1024 NumPoles 1 NumZeros 1 x=0 y=7 <=== WTAF! x=1 y=839 x=2 y=1663 x=3 y=2495 x=4 y=3263 x=5 y=3935 x=6 y=4527 x=7 y=5055 x=8 y=5559 ... After this patch, the standard sRGB gamma curve inverts to: x=0 y=0 <=== More better. x=1 y=839 x=2 y=1663 x=3 y=2495 x=4 y=3263 x=5 y=3935 x=6 y=4527 x=7 y=5055 x=8 y=5559 ...
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
linux_android_rel_ng is well busted, so we are not going anywhere soon.
noel@chromium.org changed reviewers: - mikelawther@chromium.org
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
noel@chromium.org changed reviewers: + kbr@chromium.org
Ken, read from #7 down.
Good work continuing to find and fix issues in this area. LGTM
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/76e01b257d0d9962c5ce98087bed10f5892520ea Cr-Commit-Position: refs/heads/master@{#336401} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
