Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(166)

Issue 1215583002: [qcms] lut_inverse_interp16: fix black level inversion error (Closed)

Created:
4 years, 4 months ago by Noel Gordon
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Mike Lawther (Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] lut_inverse_interp16: fix black level inversion error Inverting a TRC curve that is 0 at the origin should produce 0 at the origin to avoid a black level error. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel BUG=504681 Committed: https://crrev.com/76e01b257d0d9962c5ce98087bed10f5892520ea Cr-Commit-Position: refs/heads/master@{#336401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
Noel Gordon
linux_android_rel_ng intermittently failing, not that Android uses qcms.
4 years, 4 months ago (2015-06-26 05:29:35 UTC) #2
Noel Gordon
Also filed crbug.com/504703 inspector-protocol/debugger/debugger-step-into-dedicated-worker.html is a flaky crash, and uploaded a TestExpectations change to mark ...
4 years, 4 months ago (2015-06-26 05:32:33 UTC) #3
Noel Gordon
On 2015/06/26 05:32:33, noel gordon wrote: > Also filed crbug.com/504703 > inspector-protocol/debugger/debugger-step-into-dedicated-worker.html is a flaky ...
4 years, 4 months ago (2015-06-26 05:34:14 UTC) #4
Noel Gordon
Flake expectation landed https://src.chromium.org/viewvc/blink?view=rev&revision=197890
4 years, 4 months ago (2015-06-26 05:39:52 UTC) #5
Noel Gordon
> linux_android_rel_ng intermittently failing, not that Android uses qcms. Filed https://code.google.com/p/chromium/issues/detail?id=504707 about linux_android_rel_ng perf test ...
4 years, 4 months ago (2015-06-26 05:45:33 UTC) #6
Noel Gordon
Before this patch, the standard sRGB gamma curve inverts to: lut_inverse_interp16 invert_lut length=1024 out_length=1024 NumPoles ...
4 years, 4 months ago (2015-06-26 06:06:47 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
4 years, 4 months ago (2015-06-26 07:03:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/38383)
4 years, 4 months ago (2015-06-26 09:10:42 UTC) #11
Noel Gordon
linux_android_rel_ng is well busted, so we are not going anywhere soon.
4 years, 4 months ago (2015-06-26 09:15:03 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
4 years, 4 months ago (2015-06-26 12:24:01 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2015-06-26 13:22:10 UTC) #17
Noel Gordon
Ken, read from #7 down.
4 years, 4 months ago (2015-06-26 13:27:42 UTC) #19
Ken Russell (switch to Gerrit)
Good work continuing to find and fix issues in this area. LGTM
4 years, 4 months ago (2015-06-26 16:43:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215583002/1
4 years, 4 months ago (2015-06-26 17:42:17 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2015-06-26 17:50:22 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2015-06-26 17:51:14 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e01b257d0d9962c5ce98087bed10f5892520ea
Cr-Commit-Position: refs/heads/master@{#336401}

Powered by Google App Engine
This is Rietveld 408576698