net/socket/tcp_socket_win.cc - Issue 1215543003: Add UMA for the kernel's TCP RTT estimate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_socket_win.cc

Issue 1215543003: Add UMA for the kernel's TCP RTT estimate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add WARN_UNUSED_RESULT. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_socket_win.cc

diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc

index 2620ebaf70138edc79c580d53b3d1f8f08cb04f7..592c00dc1c245dd6c7d22112649f85a905a0bfdb 100644

--- a/net/socket/tcp_socket_win.cc

+++ b/net/socket/tcp_socket_win.cc

@@ -1043,4 +1043,11 @@ void TCPSocketWin::DidSignalRead() {

base::ResetAndReturn(&read_callback_).Run(rv);

}

+bool TCPSocketWin::GetEstimatedRoundTripTime(base::TimeDelta* out_rtt) const {

+ DCHECK(out_rtt);

+ // TODO(bmcquade): Consider implementing using

+ // GetPerTcpConnectionEStats/GetPerTcp6ConnectionEStats.

+ return false;

} // namespace net

« no previous file with comments | « net/socket/tcp_socket_win.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »