Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1215533005: Fix some clang warnings with -Wmissing-braces in rlz. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some clang warnings with -Wmissing-braces in rlz. Clang warns if there are missing braces around a subobject initializer. BUG=505297 Committed: https://crrev.com/f2e9443673c96bdc03319daf3ce7879156c24ad8 Cr-Commit-Position: refs/heads/master@{#337085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M rlz/win/lib/process_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 5 months ago (2015-07-01 18:35:02 UTC) #2
Nico
lgtm The "the most common idiom" thing doesn't apply here
5 years, 5 months ago (2015-07-01 18:43:12 UTC) #3
dcheng
On 2015/07/01 at 18:43:12, thakis wrote: > lgtm > > The "the most common idiom" ...
5 years, 5 months ago (2015-07-01 18:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215533005/1
5 years, 5 months ago (2015-07-01 18:46:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 19:14:56 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 19:16:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2e9443673c96bdc03319daf3ce7879156c24ad8
Cr-Commit-Position: refs/heads/master@{#337085}

Powered by Google App Engine
This is Rietveld 408576698