Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1215523004: Pass arguments to SkRecords structs by const&. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pass arguments to SkRecords structs by const&. This has the effect of using delay_copy() on every argument, obviating the need for delay_copy() and, crucially, having to remember to call delay_copy(). All these constructors are fully inlined, so we'll never pay a penalty for passing small things by reference... the compiler can see that and just pass by value. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c845fa0788a2c7eb4f4a094d7a041edf979099c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -77 lines) Patch
M src/core/SkRecorder.cpp View 10 chunks +22 lines, -43 lines 0 comments Download
M src/core/SkRecords.h View 2 chunks +37 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 5 months ago (2015-06-30 15:17:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215523004/1
5 years, 5 months ago (2015-06-30 15:17:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 15:24:34 UTC) #6
reed1
lgtm
5 years, 5 months ago (2015-06-30 16:36:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215523004/1
5 years, 5 months ago (2015-06-30 16:49:13 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:49:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c845fa0788a2c7eb4f4a094d7a041edf979099c1

Powered by Google App Engine
This is Rietveld 408576698