Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1215513004: Revert of Let GC select the collector when the external memory allocation limit is reached (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Let GC select the collector when the external memory allocation limit is reached (patchset #1 id:1 of https://codereview.chromium.org/1201993002/) Reason for revert: results in a scavenge storm if scavenge doesn't free enough memory Original issue's description: > Let GC select the collector when the external memory allocation limit is reached > > BUG=none > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/93d6216099b60e95bc816bcc913f8f841ee795b6 > Cr-Commit-Position: refs/heads/master@{#29235} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/5344fe517cdc0738e2f9c2af5153654409e527ac Cr-Commit-Position: refs/heads/master@{#29383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Let GC select the collector when the external memory allocation limit is ...
5 years, 5 months ago (2015-06-30 15:14:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215513004/1
5 years, 5 months ago (2015-06-30 15:14:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 15:14:43 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 15:15:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5344fe517cdc0738e2f9c2af5153654409e527ac
Cr-Commit-Position: refs/heads/master@{#29383}

Powered by Google App Engine
This is Rietveld 408576698