Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1215513003: Revert "Mark static function getters as used in codegen." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaFunctionCompiler implements FunctionCompiler { 7 class SsaFunctionCompiler implements FunctionCompiler {
8 SsaCodeGeneratorTask generator; 8 SsaCodeGeneratorTask generator;
9 SsaBuilderTask builder; 9 SsaBuilderTask builder;
10 SsaOptimizerTask optimizer; 10 SsaOptimizerTask optimizer;
(...skipping 3383 matching lines...) Expand 10 before | Expand all | Expand 10 after
3394 generateInstanceGetterWithCompiledReceiver( 3394 generateInstanceGetterWithCompiledReceiver(
3395 node, elements.getSelector(node), elements.getTypeMask(node), receiver); 3395 node, elements.getSelector(node), elements.getTypeMask(node), receiver);
3396 } 3396 }
3397 3397
3398 /// Generate a closurization of the static or top level [function]. 3398 /// Generate a closurization of the static or top level [function].
3399 void generateStaticFunctionGet(ast.Send node, MethodElement function) { 3399 void generateStaticFunctionGet(ast.Send node, MethodElement function) {
3400 generateIsDeferredLoadedCheckOfSend(node); 3400 generateIsDeferredLoadedCheckOfSend(node);
3401 // TODO(5346): Try to avoid the need for calling [declaration] before 3401 // TODO(5346): Try to avoid the need for calling [declaration] before
3402 // creating an [HStatic]. 3402 // creating an [HStatic].
3403 push(new HStatic(function.declaration, backend.nonNullType)); 3403 push(new HStatic(function.declaration, backend.nonNullType));
3404 // TODO(ahe): This should be registered in codegen.
3405 registry.registerGetOfStaticFunction(function.declaration);
3404 } 3406 }
3405 3407
3406 /// Read a local variable, function or parameter. 3408 /// Read a local variable, function or parameter.
3407 void handleLocalGet(LocalElement local) { 3409 void handleLocalGet(LocalElement local) {
3408 stack.add(localsHandler.readLocal(local)); 3410 stack.add(localsHandler.readLocal(local));
3409 } 3411 }
3410 3412
3411 @override 3413 @override
3412 void visitDynamicPropertyGet( 3414 void visitDynamicPropertyGet(
3413 ast.Send node, 3415 ast.Send node,
(...skipping 4744 matching lines...) Expand 10 before | Expand all | Expand 10 after
8158 if (unaliased is TypedefType) throw 'unable to unalias $type'; 8160 if (unaliased is TypedefType) throw 'unable to unalias $type';
8159 unaliased.accept(this, builder); 8161 unaliased.accept(this, builder);
8160 } 8162 }
8161 8163
8162 void visitDynamicType(DynamicType type, SsaBuilder builder) { 8164 void visitDynamicType(DynamicType type, SsaBuilder builder) {
8163 JavaScriptBackend backend = builder.compiler.backend; 8165 JavaScriptBackend backend = builder.compiler.backend;
8164 ClassElement cls = backend.findHelper('DynamicRuntimeType'); 8166 ClassElement cls = backend.findHelper('DynamicRuntimeType');
8165 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld))); 8167 builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
8166 } 8168 }
8167 } 8169 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698