Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1215503009: Remove an instance of isPropertyImplicit from StylePropertySerializer.cpp. (Closed)

Created:
5 years, 5 months ago by meade_UTC10
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, mstensho (USE GERRIT), rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove an instance of isPropertyImplicit from StylePropertySerializer.cpp. This affects the output for the -webkit-columns shorthand: "-webkit-columns: 10px;" -> '10px auto' Update tests to reflect this. BUG=471917 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198045

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M LayoutTests/fast/css/getPropertyValue-columns.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/getPropertyValue-columns-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/columns-shorthand-parsing-2.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/multicol/columns-shorthand-parsing-2-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +12 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 1219643002 Patch 130001
Issue 1219643002 Patch 150001

Messages

Total messages: 6 (2 generated)
meade_UTC10
5 years, 5 months ago (2015-06-30 07:57:32 UTC) #2
Timothy Loh
On 2015/06/30 07:57:32, Eddy wrote: lgtm
5 years, 5 months ago (2015-06-30 08:12:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215503009/40001
5 years, 5 months ago (2015-06-30 08:27:37 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 09:43:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198045

Powered by Google App Engine
This is Rietveld 408576698