Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2594)

Unified Diff: src/IceCompileServer.cpp

Issue 1215463014: Modify how textual bitcode is injected into pnacl-sz. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceBuildDefs.h ('K') | « src/IceBuildDefs.h ('k') | src/Makefile » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCompileServer.cpp
diff --git a/src/IceCompileServer.cpp b/src/IceCompileServer.cpp
index 23874f0f5ac48b443c8945155e95ccda9e782c2f..02c3bbabf7e1a76948d1c8a403df5eeceee5c9ae 100644
--- a/src/IceCompileServer.cpp
+++ b/src/IceCompileServer.cpp
@@ -22,7 +22,7 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-parameter"
// Include code to handle converting textual bitcode records to binary (for
Karl 2015/07/21 21:07:01 Removed comment, no longer dependent on ACCEPT_TEX
-// INPUT_IS_TEXTUAL_BITCODE).
+// ACCEPT_TEXTUAL_PNACL_BITCODE).
#include "llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/raw_os_ostream.h"
@@ -40,8 +40,8 @@ namespace Ice {
namespace {
static_assert(!(BuildDefs::textualBitcode() && PNACL_BROWSER_TRANSLATOR),
- "Can not define INPUT_IS_TEXTUAL_BITCODE when building browswer "
- "translator");
+ "Can not accept textual bitcode when building "
+ "browswer translator");
jvoung (off chromium) 2015/07/07 21:40:17 browswer -> browser
Karl 2015/07/21 21:07:01 Removed static_assert since it is no longer depend
// Define a SmallVector backed buffer as a data stream, so that it
// can hold the generated binary version of the textual bitcode in the
« src/IceBuildDefs.h ('K') | « src/IceBuildDefs.h ('k') | src/Makefile » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698