Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1215463008: Sync the EventSource interface with the spec (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-events_chromium.org, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the EventSource interface with the spec This change is not observable, obviously. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/page/EventSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSourceInit.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipj_slow
PTAL
5 years, 5 months ago (2015-07-06 19:39:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215463008/1
5 years, 5 months ago (2015-07-06 19:39:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 21:07:34 UTC) #6
Jens Widell
LGTM
5 years, 5 months ago (2015-07-07 08:08:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215463008/1
5 years, 5 months ago (2015-07-07 08:09:51 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:14:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198373

Powered by Google App Engine
This is Rietveld 408576698