Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

Issue 1215463006: Move nativeInfo encoding into NativeGenerator. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
index f8d369589eabcc76ce8fe19cabca17410b9b8b61..34205dca87ab7973394289fcf51bb5fd2dbaef1c 100644
--- a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
@@ -253,7 +253,8 @@ class ModelEmitter {
generateEmbeddedGlobalAccess(INTERCEPTORS_BY_TAG);
js.Expression leafTagsAccess =
generateEmbeddedGlobalAccess(LEAF_TAGS);
- js.Statement nativeInfoHandler = nativeEmitter.buildNativeInfoHandler(
+ NativeGenerator generator = new NativeGenerator();
+ js.Statement nativeInfoHandler = generator.buildNativeInfoHandler(
nativeInfoAccess,
constructorAccess,
subclassReadGenerator,
@@ -591,10 +592,11 @@ class ModelEmitter {
js.Literal name = js.quoteName(cls.name);
js.LiteralNumber holderIndex = js.number(cls.holder.index);
js.Expression emittedClass = emitClass(cls);
- if (cls.nativeInfo == null) {
+ js.Expression nativeInfo = new NativeGenerator.encodeNativeInfo(cls);
+ if (nativeInfo == null) {
return [name, emittedClass, holderIndex];
} else {
- return [name, emittedClass, cls.nativeInfo, holderIndex];
+ return [name, emittedClass, nativeInfo, holderIndex];
}
});

Powered by Google App Engine
This is Rietveld 408576698