CL for Objective-C readability

ios/web/public/crw_browsing_data_store.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_CRW_BROWSING_DATA_STORE_H_
 #define IOS_WEB_CRW_BROWSING_DATA_STORE_H_
 
 #import <Foundation/Foundation.h>
 
 #import "base/ios/block_types.h"
@@ skipping 36 matching lines @@
 // state of the |web::ActiveStateManager| associated with |browserState|.
 - (instancetype)initWithBrowserState:(web::BrowserState*)browserState
     NS_DESIGNATED_INITIALIZER;
 
 // The delegate that is consulted when the mode needs to change.
 @property(nonatomic, weak) id<CRWBrowsingDataStoreDelegate> delegate;
 
 // The mode that the CRWBrowsingDataStore is in. KVO compliant.
 @property(nonatomic, assign, readonly) web::BrowsingDataStoreMode mode;
 
 // TODO(shreyasv): Verify the preconditions for the following 3 methods when

[stuartmorgan, 2015/06/30 21:57:18]

Isn't this an implementation note, not an interface issue? If so, it belongs in
the .mm

[shreyasv1, 2015/07/07 21:42:06]

Done.

 // web::WebViewCounter class is implemented. crbug.com/480507
 
 // Changes the mode to |ACTIVE|.
 // if there is no delegate present, the default behavior of this method is to

[stuartmorgan, 2015/06/30 21:57:18]

If

[shreyasv1, 2015/07/07 21:42:05]

Done.

 // restore browsing data from |browserState|'s stash path to the canonical path
 // where web views read/write browsing data to.
 // |completionHandler| is called on the main thread. This block has no return
 // value and takes a single BOOL argument that indicates whether or not the
 // the mode was successfully changed to |ACTIVE|.
 // The mode change to |ACTIVE| can fail if another |makeActive| or
 // |makeInactive| was enqueued after this call.
 // Precondition: There must be no web views associated with the BrowserState.
 - (void)makeActiveWithCompletionHandler:
         (void (^)(BOOL success))completionHandler;
 
 // Changes the mode to |INACTIVE|.
 // if there is no delegate present, the default behavior of this method is to

[stuartmorgan, 2015/06/30 21:57:18]

If

[shreyasv1, 2015/07/07 21:42:06]

Done.

 // value and takes a single BOOL argument that indicates whether or not the

[stuartmorgan, 2015/06/30 21:57:18]

Looks like a line or two of comments is missing.

[shreyasv1, 2015/07/07 21:42:05]

Done.

 // stash browsing data created by the web view in to |browserState|'s stash
 // path.
 // |completionHandler| is called on the main thread. This block has no return
 // value and takes a single BOOL argument that indicates whether or not the
 // the mode was successfully changed to |INACTIVE|.

[stuartmorgan, 2015/06/30 21:57:18]

... or maybe just partially duplicated

[shreyasv1, 2015/07/07 21:42:06]

Done.

 // The mode change to |ACTIVE| can fail if another |makeActive| or

[stuartmorgan, 2015/06/30 21:57:18]

INACTIVE

[shreyasv1, 2015/07/07 21:42:06]

Done.

 // |makeInactive| was enqueued after this call.
 // Precondition: There must be no web views associated with the BrowserState.
 - (void)makeInactiveWithCompletionHandler:
         (void (^)(BOOL success))completionHandler;
 
 // Removes all browsing data of the provided |browsingDataTypes|.
 // |completionHandler| is called on the main thread after the browsing data has
 // been removed.
 // Precondition: There must be no web views associated with the BrowserState.
 - (void)removeDataOfTypes:(web::BrowsingDataTypes)browsingDataTypes
         completionHandler:(ProceduralBlock)completionHandler;
 
 // Returns YES if there is still a pending operation that has not finished

[stuartmorgan, 2015/06/30 21:57:18]

Properties should not use the method descriptive verb structure.

[shreyasv1, 2015/07/07 21:42:06]

Done.

 // running. Creating web views (UIWebViews and WKWebViews) with this
 // CRWBrowsingDataStore when there are pending operations is undefined

[stuartmorgan, 2015/06/30 21:57:18]

s/is/results in/

[shreyasv1, 2015/07/07 21:42:05]

Done.

 // behavior.
 @property(nonatomic, assign, readonly) BOOL hasPendingOperations;

[stuartmorgan, 2015/06/30 21:57:18]

This should be declared up with the other properties, before the methods.

[shreyasv1, 2015/07/07 21:42:06]

Done.

 
 @end
 
 #endif  // IOS_WEB_CRW_BROWSING_DATA_STORE_H_
+