Set AES key and IV mask to CastSender

Set AES key and IV mask to CastSender

Adding parameters to Cast Streaming Extensions API to configure
AES encryption key and IV mask to CastSender.

BUG=315931
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243540

[haibinlu, 2013-12-27 01:15:40]

lgtm

[not at google - send to devlin, 2013-12-27 10:35:22]

lgtm with comments

https://codereview.chromium.org/121543003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cast_streaming_rtp_stream.idl (right):

https://codereview.chromium.org/121543003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cast_streaming_rtp_stream.idl:42: DOMString?
aes_key;
fwiw we have both styles here now, maxBitrate and aes_key. Since there's already
feedback_ssrc perhaps this should be aesKey and aesIvMask and change the
feedback one later.

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/cast_streaming/basics.js (right):

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:12:
console.log("[TEST] rtpStreamStart");
this should happen automatically?

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:41:
console.log("[TEST] invalidKey");
ditto. is something not working?

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:42:
tabCapture.capture({audio: true, video: true}, function(stream) {
you should probably be wrapping all callbacks (here and above) in a
chrome.test.callbackPass (idiomatically people seem to alias that to "pass").

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:53:
rtpStream.start(videoId, videoParams);
need a comment somewhere around here indicating what is expected to fail and
why. perhaps also fail the test at this point if an exception hasn't been
thrown.

[Alpha Left Google, 2013-12-27 21:57:07]

https://codereview.chromium.org/121543003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cast_streaming_rtp_stream.idl (right):

https://codereview.chromium.org/121543003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cast_streaming_rtp_stream.idl:42: DOMString?
aes_key;
On 2013/12/27 10:35:22, kalman wrote:
> fwiw we have both styles here now, maxBitrate and aes_key. Since there's
already
> feedback_ssrc perhaps this should be aesKey and aesIvMask and change the
> feedback one later.

Good catch. It is supposed to be in camelcase.

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/cast_streaming/basics.js (right):

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:12:
console.log("[TEST] rtpStreamStart");
On 2013/12/27 10:35:22, kalman wrote:
> this should happen automatically?

I didn't see that in the log. Only [SUCCESS]***.

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:41:
console.log("[TEST] invalidKey");
On 2013/12/27 10:35:22, kalman wrote:
> ditto. is something not working?

Same here I couldn't see the message when a start test.

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:42:
tabCapture.capture({audio: true, video: true}, function(stream) {
On 2013/12/27 10:35:22, kalman wrote:
> you should probably be wrapping all callbacks (here and above) in a
> chrome.test.callbackPass (idiomatically people seem to alias that to "pass").

Done.

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:53:
rtpStream.start(videoId, videoParams);
On 2013/12/27 10:35:22, kalman wrote:
> need a comment somewhere around here indicating what is expected to fail and
> why. perhaps also fail the test at this point if an exception hasn't been
> thrown.

Done.

I'll probably punt having the correct AES key in a separate test and CL.

[commit-bot: I haz the power, 2013-12-27 21:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/121543003/100001

[commit-bot: I haz the power, 2013-12-27 22:14:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Alpha Left Google, 2013-12-27 22:31:51]

dalecurtis: owners approval.

[not at google - send to devlin, 2013-12-27 22:56:58]

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/api_test/cast_streaming/basics.js (right):

https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/cast_streaming/basics.js:12:
console.log("[TEST] rtpStreamStart");
On 2013/12/27 21:57:07, Alpha wrote:
> On 2013/12/27 10:35:22, kalman wrote:
> > this should happen automatically?
> 
> I didn't see that in the log. Only [SUCCESS]***.

Ah ok you're right, there is no logging, sorry. Why do you need to log it? I
wuoldn't mind adding it for all tests (in test_custom_bindings.js) if it's
generally useful. It'd also be interesting to record test runtime...

you or I or somebody else could do this in a follow-up though obviously.

[Alpha Left Google, 2013-12-27 22:58:39]

On 2013/12/27 22:56:58, kalman wrote:
>
https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
> File chrome/test/data/extensions/api_test/cast_streaming/basics.js (right):
> 
>
https://codereview.chromium.org/121543003/diff/1/chrome/test/data/extensions/...
> chrome/test/data/extensions/api_test/cast_streaming/basics.js:12:
> console.log("[TEST] rtpStreamStart");
> On 2013/12/27 21:57:07, Alpha wrote:
> > On 2013/12/27 10:35:22, kalman wrote:
> > > this should happen automatically?
> > 
> > I didn't see that in the log. Only [SUCCESS]***.
> 
> Ah ok you're right, there is no logging, sorry. Why do you need to log it? I
> wuoldn't mind adding it for all tests (in test_custom_bindings.js) if it's
> generally useful. It'd also be interesting to record test runtime...
> 
> you or I or somebody else could do this in a follow-up though obviously.

I find it useful to know which test is running and which test fails to fun. It's
a bit hard to parse the log if there's no than one test case.

[Alpha Left Google, 2014-01-07 03:50:02]

Ping chrome/renderer/media owners.

[Alpha Left Google, 2014-01-08 00:23:05]

+scherkus

[Alpha Left Google, 2014-01-08 00:23:05]

+scherkus

[scherkus (not reviewing), 2014-01-08 00:25:45]

lgtm

[commit-bot: I haz the power, 2014-01-08 00:27:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/121543003/100001

[commit-bot: I haz the power, 2014-01-08 02:53:25]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 02:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/121543003/100001

[commit-bot: I haz the power, 2014-01-08 05:01:44]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 08:11:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/121543003/100001

[commit-bot: I haz the power, 2014-01-08 12:48:55]

Change committed as 243540