Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1215393002: Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc Committed: https://skia.googlesource.com/skia/+/1b24933e52f50773de29332387a12721811f3012

Patch Set 1 #

Patch Set 2 : freetype #

Patch Set 3 : fontconfig #

Patch Set 4 : skimagefilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -105 lines) Patch
M bench/MutexBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RefCntBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DM.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMJsonWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/core/SkThread.h View 1 chunk +0 lines, -16 lines 0 comments Download
M include/core/SkWeakRefCnt.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkAAClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapHeap.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkCachedData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDeviceProfile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDrawable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGlyphCache.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkGlyphCache_Globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkMessageBus.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPath.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.cpp View 6 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkString.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkTLS.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkTypefaceCache.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkRemotableFontMgr_win_dw.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkTLS_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEventSink.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/views/SkOSMenu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsExtendedTest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpdiff/SkDiffContext.h View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/1
5 years, 5 months ago (2015-07-01 20:08:29 UTC) #2
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 20:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/20001
5 years, 5 months ago (2015-07-01 20:22:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1848)
5 years, 5 months ago (2015-07-01 20:24:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/40001
5 years, 5 months ago (2015-07-01 20:25:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/1659)
5 years, 5 months ago (2015-07-01 20:30:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/60001
5 years, 5 months ago (2015-07-01 20:49:05 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc
5 years, 5 months ago (2015-07-01 21:01:02 UTC) #15
jvanverth1
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1214603003/ by jvanverth@google.com. ...
5 years, 5 months ago (2015-07-02 13:42:17 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/60001
5 years, 5 months ago (2015-07-07 19:07:47 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 19:15:24 UTC) #20
mtklein
Hey sheriff, going to try landing this again. It broke the roll last time, but ...
5 years, 5 months ago (2015-07-07 19:19:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215393002/60001
5 years, 5 months ago (2015-07-07 19:20:24 UTC) #23
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 19:21:26 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1b24933e52f50773de29332387a12721811f3012

Powered by Google App Engine
This is Rietveld 408576698