Issue 1215333012: Revert of [d8] bounds-check before getting Shell::Worker internal field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215333012: Revert of [d8] bounds-check before getting Shell::Worker internal field (Closed)

Created:
5 years, 5 months ago by Michael Achenbach

Modified:
5 years, 5 months ago

Reviewers:
caitp (gmail), jochen (gone - plz use gerrit), binji, adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [d8] bounds-check before getting Shell::Worker internal field (patchset #4 id:80001 of https://codereview.chromium.org/1214053004/) Reason for revert: [Sheriff] Fails here: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/4737 Original issue's description: > [d8] bounds-check before getting Shell::Worker internal field > > Prevents fatal error in debug builds > > BUG=v8:4271 > R=binji@chromium.org > LOG=N > > Committed: https://crrev.com/43ce9c6f101c4224addd9a54e0c39963188dc7fa > Cr-Commit-Position: refs/heads/master@{#29524} TBR=binji@chromium.org,jochen@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4271 Committed: https://crrev.com/650ef15c00bcec4189577652676e77c6152fc9ab Cr-Commit-Position: refs/heads/master@{#29525}

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -39 lines)			Patch
	M	src/d8.cc	View		3 chunks	+7 lines, -15 lines	0 comments	Download
	D	test/mjsunit/regress/regress-4271.js	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of [d8] bounds-check before getting Shell::Worker internal field

5 years, 5 months ago (2015-07-07 21:16:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215333012/1

5 years, 5 months ago (2015-07-07 21:16:41 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-07 21:17:09 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/650ef15c00bcec4189577652676e77c6152fc9ab
Cr-Commit-Position: refs/heads/master@{#29525}