Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1215333005: [turbofan] Perform OSR deconstruction early and remove type propagation. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
titzer, Jarin
CC:
v8-dev, titzer, Michael Starzinger, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Perform OSR deconstruction early and remove type propagation. This way we don't have to deal with dead pre-OSR code in the graph and risk optimizing the wrong code, especially we don't make optimistic assumptions in the dead code that leaks into the OSR code (i.e. deopt guards are in dead code, but the types propagate to OSR code via the OsrValue type back propagation). BUG=v8:4273 LOG=n R=jarin@chromium.org Committed: https://crrev.com/cdbb6c485b8d07fd4ad1cb000d54a937507e3b3e Cr-Commit-Position: refs/heads/master@{#29478}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -82 lines) Patch
M src/compiler/osr.cc View 2 chunks +0 lines, -37 lines 2 comments Download
M src/compiler/pipeline.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-06 08:43:14 UTC) #1
Benedikt Meurer
Hey Jaro, The next step in fixing the OSR. Removing the dangerous code and deconstructing ...
5 years, 5 months ago (2015-07-06 08:44:07 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-07-06 08:54:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215333005/1
5 years, 5 months ago (2015-07-06 09:05:35 UTC) #5
titzer
https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc File src/compiler/osr.cc (left): https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc#oldcode253 src/compiler/osr.cc:253: Node* osr_loop) { I don't think it's necessary to ...
5 years, 5 months ago (2015-07-06 09:12:34 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc File src/compiler/osr.cc (left): https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc#oldcode253 src/compiler/osr.cc:253: Node* osr_loop) { This is the main cause for ...
5 years, 5 months ago (2015-07-06 09:15:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 09:15:20 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 09:15:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdbb6c485b8d07fd4ad1cb000d54a937507e3b3e
Cr-Commit-Position: refs/heads/master@{#29478}

Powered by Google App Engine
This is Rietveld 408576698