Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1215313004: Tab bar should have white indicator if primary and accent color are the same (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Tab bar should have white indicator if primary and accent color are the same R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/91df367a11c3c255b25181b4ea44f3fe91f4fd23

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M sky/sdk/lib/widgets/tabs.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M sky/tests/examples/stocks-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/examples/tabs-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 5 months ago (2015-07-07 00:57:32 UTC) #2
jackson
5 years, 5 months ago (2015-07-07 22:35:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
91df367a11c3c255b25181b4ea44f3fe91f4fd23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698