bluetooth: android: Initial BluetoothDeviceAndroid implementation.

device/bluetooth/bluetooth_adapter_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_
 
 #include "base/android/jni_android.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/memory/weak_ptr.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 
 namespace base {
 class SequencedTaskRunner;
 }  // namespace base
 
 using base::android::ScopedJavaLocalRef;
 
 namespace device {
 
 // BluetoothAdapterAndroid, along with the Java class
 // org.chromium.device.bluetooth.BluetoothAdapter, implement BluetoothAdapter.
 //
 // The GATT Profile over Low Energy is supported, but not Classic Bluetooth at
 // this time. LE GATT support has been initially built out to support Web
 // Bluetooth, which does not need other Bluetooth features. There is no
 // technical reason they can not be supported should a need arrise.
 //
 // BluetoothAdapterAndroid is reference counted, and owns the lifetime of the
-// Java class BluetoothAdapter via j_adapter_.
+// Java class BluetoothAdapter via j_adapter_. A tree of additional C++ objects

[Jeffrey Yasskin, 2015/07/07 00:11:14]

"The adapter also owns a tree of ..."

[scheib, 2015/07/08 00:49:10]

Done.

+// (Devices, Services, Characteristics, Descriptors) are also owned, with each
+// C++ object owning its associated Java class.
 class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterAndroid final
     : public BluetoothAdapter {
  public:
   // Create a BluetoothAdapterAndroid instance.
   //
   // |java_bluetooth_adapter_wrapper| is optional. If it is NULL the adapter
   // will return false for |IsPresent()| and not be functional.
   //
   // The BluetoothAdapterAndroid instance will indirectly hold a Java reference
   // to |java_bluetooth_adapter_wrapper|.
@@ skipping 35 matching lines @@
       const AcquiredCallback& callback,
       const BluetoothAudioSink::ErrorCallback& error_callback) override;
   void RegisterAdvertisement(
       scoped_ptr<BluetoothAdvertisement::Data> advertisement_data,
       const CreateAdvertisementCallback& callback,
       const CreateAdvertisementErrorCallback& error_callback) override;
 
   // Handles a scan error event by invalidating all discovery sessions.
   void OnScanFailed(JNIEnv* env, jobject obj);
 
+  // Creates or updates device with advertised UUID information when a device is
+  // discovered during a scan.
+  void CreateOrUpdateDeviceOnScan(JNIEnv* env,
+                                  jobject obj,

[Jeffrey Yasskin, 2015/07/07 00:11:14]

What's |obj|? Maybe comment the expected types for all three jobjects?

[scheib, 2015/07/08 00:49:10]

The first two parameters are standard JNI form. I've kicked off
https://codereview.chromium.org/1212443006/ to improve that.

[Jeffrey Yasskin, 2015/07/08 17:19:38]

Cool, thanks.

Should bluetooth_device_wrapper and advertised_uuids also mention their expected
types?

[scheib, 2015/07/08 23:02:34]

OK. /shrug/ this is a bit of a mess, and the C++ code only passes these objects
through, but why not.

+                                  const jstring& address,
+                                  jobject bluetooth_device_wrapper,
+                                  jobject advertised_uuids);
+
  protected:
   BluetoothAdapterAndroid();
   ~BluetoothAdapterAndroid() override;
 
   // BluetoothAdapter:
   void AddDiscoverySession(BluetoothDiscoveryFilter* discovery_filter,
                            const base::Closure& callback,
                            const ErrorCallback& error_callback) override;
   void RemoveDiscoverySession(BluetoothDiscoveryFilter* discovery_filter,
                               const base::Closure& callback,
@@ skipping 13 matching lines @@
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<BluetoothAdapterAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterAndroid);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_ANDROID_H_