Issue 12153003: Add RenderTextLinux Heapcheck and Valgrind suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12153003: Add RenderTextLinux Heapcheck and Valgrind suppressions. (Closed)

Created:
7 years, 10 months ago by msw

Modified:
7 years, 10 months ago

Reviewers:
Alexei Svitkine (slow), sky

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add RenderTextLinux Heapcheck and Valgrind suppressions. Links to first failures after my CL: https://src.chromium.org/viewvc/chrome?view=rev&revision=180067 http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/20475 http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/24259 I'm planning to suppress the errors in an impending CL. BUG=173597 TEST=No unsuppressed RenderTextLinux leaks. TBR=asvitkine@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180106

Patch Set 2 : Rebase #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+19 lines, -0 lines	1 comment	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+19 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Two nits. I'll fix those for you. https://codereview.chromium.org/12153003/diff/2001/tools/heapcheck/suppressions.txt File tools/heapcheck/suppressions.txt (right): https://codereview.chromium.org/12153003/diff/2001/tools/heapcheck/suppressions.txt#newcode1850 tools/heapcheck/suppressions.txt:1850: bug_173597_a nit: ...

7 years, 10 months ago (2013-02-01 10:11:47 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 12153003: Add RenderTextLinux Heapcheck and Valgrind suppressions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Messages