Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1215273003: [test] Let perf runner interleave try executions. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
ulan, tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Let perf runner interleave try executions. This allows running two executables interleaved to reduce flakiness of tryjobs. The executables must reside in different out directories. BUG=chromium:507213 LOG=n NOTRY=true TEST=python -m unittest run_perf_test Committed: https://crrev.com/e925e0b69ffffec183083765c3b362a77ad50228 Cr-Commit-Position: refs/heads/master@{#29572}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Test case #

Total comments: 3

Patch Set 4 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -48 lines) Patch
M tools/run_perf.py View 1 2 3 16 chunks +160 lines, -41 lines 0 comments Download
M tools/unittests/run_perf_test.py View 1 2 3 2 chunks +46 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1215273003/diff/40001/tools/unittests/run_perf_test.py File tools/unittests/run_perf_test.py (left): https://codereview.chromium.org/1215273003/diff/40001/tools/unittests/run_perf_test.py#oldcode414 tools/unittests/run_perf_test.py:414: "--arch", "android_arm")) Unrelated fix.
5 years, 5 months ago (2015-07-10 10:45:33 UTC) #2
ulan
lgtm https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py#newcode229 tools/run_perf.py:229: def Unchain(iterable): This function is usually called 'unzip' ...
5 years, 5 months ago (2015-07-10 10:54:16 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py#newcode229 tools/run_perf.py:229: def Unchain(iterable): On 2015/07/10 10:54:16, ulan wrote: > This ...
5 years, 5 months ago (2015-07-10 13:00:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215273003/60001
5 years, 5 months ago (2015-07-10 13:00:39 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-10 13:02:13 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 13:02:36 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e925e0b69ffffec183083765c3b362a77ad50228
Cr-Commit-Position: refs/heads/master@{#29572}

Powered by Google App Engine
This is Rietveld 408576698