Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: test/mjsunit/d8-worker-sharedarraybuffer.js

Issue 1215233004: Fix bug when transferring SharedArrayBuffer to multiple Workers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: internalize transferred ArrayBuffer Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/d8.cc ('K') | « src/d8.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --harmony-sharedarraybuffer --harmony-atomics 28 // Flags: --harmony-sharedarraybuffer --harmony-atomics
29 29
30 var workerScript = 30 if (this.Worker) {
31 `onmessage = function(m) {
32 var sab = m;
33 var ta = new Uint32Array(sab);
34 if (sab.byteLength !== 16) {
35 throw new Error('SharedArrayBuffer transfer byteLength');
36 }
37 for (var i = 0; i < 4; ++i) {
38 if (ta[i] !== i) {
39 throw new Error('SharedArrayBuffer transfer value ' + i);
40 }
41 }
42 // Atomically update ta[0]
43 Atomics.store(ta, 0, 100);
44 };`;
45 31
46 if (this.Worker) { 32 (function TestTransfer() {
47 var w = new Worker(workerScript); 33 var workerScript =
34 `onmessage = function(m) {
35 var sab = m;
36 var ta = new Uint32Array(sab);
37 if (sab.byteLength !== 16) {
38 throw new Error('SharedArrayBuffer transfer byteLength');
39 }
40 for (var i = 0; i < 4; ++i) {
41 if (ta[i] !== i) {
42 throw new Error('SharedArrayBuffer transfer value ' + i);
43 }
44 }
45 // Atomically update ta[0]
46 Atomics.store(ta, 0, 100);
47 };`;
48 48
49 var sab = new SharedArrayBuffer(16); 49 var w = new Worker(workerScript);
50 var ta = new Uint32Array(sab);
51 for (var i = 0; i < 4; ++i) {
52 ta[i] = i;
53 }
54 50
55 // Transfer SharedArrayBuffer 51 var sab = new SharedArrayBuffer(16);
56 w.postMessage(sab, [sab]); 52 var ta = new Uint32Array(sab);
57 assertEquals(16, sab.byteLength); // ArrayBuffer should not be neutered. 53 for (var i = 0; i < 4; ++i) {
54 ta[i] = i;
55 }
58 56
59 // Spinwait for the worker to update ta[0] 57 // Transfer SharedArrayBuffer
60 var ta0; 58 w.postMessage(sab, [sab]);
61 while ((ta0 = Atomics.load(ta, 0)) == 0) {} 59 assertEquals(16, sab.byteLength); // ArrayBuffer should not be neutered.
62 60
63 assertEquals(100, ta0); 61 // Spinwait for the worker to update ta[0]
62 var ta0;
63 while ((ta0 = Atomics.load(ta, 0)) == 0) {}
64 64
65 w.terminate(); 65 assertEquals(100, ta0);
66 66
67 assertEquals(16, sab.byteLength); // Still not neutered. 67 w.terminate();
68
69 assertEquals(16, sab.byteLength); // Still not neutered.
70 })();
71
72 (function TestTransferMulti() {
73 var workerScript =
74 `onmessage = function(msg) {
75 var sab = msg.sab;
76 var id = msg.id;
77 var ta = new Uint32Array(sab);
78 Atomics.store(ta, id, 1);
79 postMessage(id);
80 };`;
81
82 var sab = new SharedArrayBuffer(16);
83 var ta = new Uint32Array(sab);
84
85 var id;
86 var workers = [];
87 for (id = 0; id < 4; ++id) {
88 workers[id] = new Worker(workerScript);
89 workers[id].postMessage({sab: sab, id: id}, [sab]);
90 }
91
92 // Spinwait for each worker to update ta[id]
93 var count = 0;
94 while (count < 4) {
95 for (id = 0; id < 4; ++id) {
96 if (Atomics.compareExchange(ta, id, 1, -1) == 1) {
97 // Worker is finished.
98 assertEquals(id, workers[id].getMessage());
99 workers[id].terminate();
100 count++;
101 }
102 }
103 }
104 })();
105
68 } 106 }
OLDNEW
« src/d8.cc ('K') | « src/d8.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698