chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java - Issue 1215233002: [Feedback] Add support for using callbacks for ConnectivityTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

Issue 1215233002: [Feedback] Add support for using callbacks for ConnectivityTask (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-connectivity-task-enum

Patch Set: Rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

index e1977271953affeaf4421889ebc8d79017f7329f..bbc979a379d4ae91015305e1c52a1f085874110c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

@@ -73,7 +73,8 @@ public class FeedbackCollector {

mData = new HashMap<>();

mProfile = profile;

mUrl = url;

- mConnectivityTask = ConnectivityTask.create(mProfile, DEFAULT_ASYNC_COLLECTION_TIMEOUT_MS);

+ mConnectivityTask =

+ ConnectivityTask.create(mProfile, DEFAULT_ASYNC_COLLECTION_TIMEOUT_MS, null);

}

/**