Random cleanup of various Dart things in our tree.

sky/sdk/lib/rendering/box.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:math' as math;
 import 'dart:sky' as sky;
 
 import 'package:vector_math/vector_math.dart';
 
 import '../base/debug.dart';
@@ skipping 303 matching lines @@
   double getDistanceToActualBaseline(TextBaseline baseline) {
     assert(!needsLayout);
     return null;
   }
 
   BoxConstraints get constraints => super.constraints;
   bool debugDoesMeetConstraints() {
     assert(constraints != null);
     assert(_size != null);
     assert(!_size.isInfinite);
-    return constraints.contains(_size);
+    bool result = constraints.contains(_size);
+    if (!result)
+      print("${this.runtimeType} does not meet its constraints. Constraints: $constraints, size: $_size");
+    return result;
   }
   void performResize() {
     // default behaviour for subclasses that have sizedByParent = true
     size = constraints.constrain(Size.zero);
     assert(!size.isInfinite);
   }
   void performLayout() {
     // descendants have to either override performLayout() to set both
     // width and height and lay out children, or, set sizedByParent to
     // true so that performResize()'s logic above does its thing.
@@ skipping 421 matching lines @@
 
   double getMaxIntrinsicHeight(BoxConstraints constraints) {
     double totalPadding = padding.top + padding.bottom;
     if (child != null)
       return child.getMaxIntrinsicHeight(constraints.deflate(padding)) + totalPadding;
     return constraints.constrainHeight(totalPadding);
   }
 
   void performLayout() {
     assert(padding != null);
-    BoxConstraints innerConstraints = constraints.deflate(padding);
     if (child == null) {
-      size = innerConstraints.constrain(
-          new Size(padding.left + padding.right, padding.top + padding.bottom));
+      size = constraints.constrain(new Size(
+        padding.left + padding.right,
+        padding.top + padding.bottom
+      ));
       return;
     }
+    BoxConstraints innerConstraints = constraints.deflate(padding);
     child.layout(innerConstraints, parentUsesSize: true);
     assert(child.parentData is BoxParentData);
     child.parentData.position = new Point(padding.left, padding.top);
-    size = constraints.constrain(new Size(padding.left + child.size.width + padding.right,
-                                              padding.top + child.size.height + padding.bottom));
+    size = constraints.constrain(new Size(
+      padding.left + child.size.width + padding.right,
+      padding.top + child.size.height + padding.bottom
+    ));
   }
 
   String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}padding: ${padding}\n';
 }
 
 class RenderPositionedBox extends RenderShiftedBox {
 
   RenderPositionedBox({
     RenderBox child,
     double horizontal: 0.5,
@@ skipping 360 matching lines @@
 
   ViewConstraints _rootConstraints;
   ViewConstraints get rootConstraints => _rootConstraints;
   void set rootConstraints(ViewConstraints value) {
     if (_rootConstraints == value)
       return;
     _rootConstraints = value;
     markNeedsLayout();
   }
 
+  // We never call layout() on this class, so this should never get
+  // checked. (This class is laid out using scheduleInitialLayout().)
+  bool debugDoesMeetConstraints() { assert(false); return false; }
+
   void performResize() {
     assert(false);
   }
 
   void performLayout() {
     if (_rootConstraints.orientation != _orientation) {
       if (_orientation != null && child != null)
         child.rotate(oldAngle: _orientation, newAngle: _rootConstraints.orientation, time: timeForRotation);
       _orientation = _rootConstraints.orientation;
     }
@@ skipping 94 matching lines @@
 
   void defaultPaint(PaintingCanvas canvas, Offset offset) {
     RenderBox child = firstChild;
     while (child != null) {
       assert(child.parentData is ParentDataType);
       canvas.paintChild(child, child.parentData.position + offset);
       child = child.parentData.nextSibling;
     }
   }
 }