Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1215153002: Add ASan lazy sweep annotations to allow Persistent<> creation. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add ASan lazy sweep annotations to allow Persistent<> creation. Destructors are allowed to allocate, including the creation of Persistent<>s and linking them into the root set. That might end up touching other objects that are in the process of being swept and are poisoned. Benign, add annotations. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/platform/heap/Handle.h View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Making this available, just in case. i.e., https://chromiumcodereview.appspot.com/1213133002/ invalidates the need for this one, but ...
5 years, 5 months ago (2015-06-30 15:14:07 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-06-30 15:15:29 UTC) #3
sof
will land this now instead, as I'd like to enable lazy sweeping. A rebase will ...
5 years, 5 months ago (2015-06-30 18:33:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215153002/1
5 years, 5 months ago (2015-06-30 18:33:49 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 18:37:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198081

Powered by Google App Engine
This is Rietveld 408576698