Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1215123002: Make deserialize-script-id test more robust. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make deserialize-script-id test more robust. R=machenbach@chromium.org BUG=v8:4127 LOG=N Committed: https://crrev.com/787de93f4cb5026cd4ebc120e70a15710164496d Cr-Commit-Position: refs/heads/master@{#29464}

Patch Set 1 #

Patch Set 2 : update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M test/mjsunit/deserialize-script-id.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 5 months ago (2015-06-30 12:15:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215123002/20001
5 years, 5 months ago (2015-06-30 12:16:09 UTC) #3
Michael Achenbach
lgtm
5 years, 5 months ago (2015-06-30 12:19:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 13:11:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215123002/20001
5 years, 5 months ago (2015-07-03 10:45:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-03 11:11:27 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 11:11:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/787de93f4cb5026cd4ebc120e70a15710164496d
Cr-Commit-Position: refs/heads/master@{#29464}

Powered by Google App Engine
This is Rietveld 408576698