Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1215103006: Improve default behavior for sky_tool start (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve default behavior for sky_tool start Previously we defaulted to main.dart, which was confusing. Now we default to the current working directory, which is more understandable. As part of this change, I've also changed the default location of main.dart to lib/main.dart, which makes our current examples. Fixes #274 R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c7278bd1f3dd08d1a8c98eeb9ff688d1eab5b5fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sky/sdk/lib/sky_tool View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 23:12:14 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-06-30 23:13:57 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-06-30 23:14:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7278bd1f3dd08d1a8c98eeb9ff688d1eab5b5fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698