Issue 1215103002: Disable -Wreorder when building with clang on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215103002: Disable -Wreorder when building with clang on Windows. (Closed)

Created:
5 years, 5 months ago by Sam McNally

Modified:
5 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	BUILD.gn	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	icu.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

Nico

On 2015/06/30 06:03:16, Sam McNally wrote: That's potentially serious. Can you file an upstream bug ...

5 years, 5 months ago (2015-06-30 06:27:26 UTC) #3

Sam McNally

On 2015/06/30 06:27:26, Nico wrote: > On 2015/06/30 06:03:16, Sam McNally wrote: > > That's ...

5 years, 5 months ago (2015-06-30 06:56:38 UTC) #4

Sam McNally

5 years, 5 months ago (2015-07-01 00:14:51 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
7fe225d77f307fdbe24695179a84336ef95c1253 (presubmit successful).