Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1215063007: Serializer forces flushing of optimized code map. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer forces flushing of optimized code map. This makes sure that the GC fully flushes the optimized code map when the serializer is preparing a snapshot. Otherwise closures and contexts could end up in the startup snapshot. R=hpayer@chromium.org TEST=cctest/test-serialize/SerializeInternalReference Committed: https://crrev.com/84f0a33ce0020f16514b8c01ff2bbe8b027e027e Cr-Commit-Position: refs/heads/master@{#29461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Hannes: PTAL. Yang: FYI.
5 years, 5 months ago (2015-07-01 16:21:43 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-02 18:26:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215063007/1
5 years, 5 months ago (2015-07-03 07:46:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 07:47:32 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 07:47:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84f0a33ce0020f16514b8c01ff2bbe8b027e027e
Cr-Commit-Position: refs/heads/master@{#29461}

Powered by Google App Engine
This is Rietveld 408576698