Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1215063006: Oilpan: disconnected scrollbars must be externally observable as such. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: disconnected scrollbars must be externally observable as such. Followup the Scrollbar and ScrollableArea Oilpan changes in r198064, and have explicit disconnects of Scrollbars from their ScrollableAreas be observable via the Scrollbar afterwards. The assumption made in r198064 that no one wanted to observe Scrollbars in that detached/disconnected state, doesn't hold. SelectorChecker and AXScrollbar are two examples. R=haraken BUG=504655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. For, https://codereview.chromium.org/1215973002/diff/20001/Source/platform/scroll/Scrollbar.cpp#newcode144 I wrongly concluded that disconnects wouldn't have to be ...
5 years, 5 months ago (2015-07-01 13:31:27 UTC) #2
haraken
LGTM Not related to this issue, but I'm still wondering why it's ok not to ...
5 years, 5 months ago (2015-07-01 13:38:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215063006/1
5 years, 5 months ago (2015-07-01 13:49:03 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 14:21:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198144

Powered by Google App Engine
This is Rietveld 408576698