Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1215063003: Remove Sky tests that we don't intend to port to the new world (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Sky tests that we don't intend to port to the new world These tests are for aspects of the Sky engine we plan to remove along with support for the old world. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/06fbe04d969b3a31413821612057cb3613693502

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -4570 lines) Patch
M sky/tests/TestExpectations View 1 chunk +1 line, -38 lines 1 comment Download
D sky/tests/animation/basic-imperative.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/tests/animation/basic-imperative-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/animation/basic-transition.sky View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/tests/animation/basic-transition-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/custom-elements/callbacks.sky View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/tests/custom-elements/callbacks-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/custom-elements/registration.sky View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/tests/custom-elements/registration-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/dart/import-lib.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/dart/import-lib-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/dart/import-lib-with-part.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/dart/import-lib-with-part-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/dart/mirror-system.sky View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/tests/dart/mirror-system-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/dart/resources/lib.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tests/dart/resources/lib-with-part.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/dart/resources/part.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tests/editing/backspace.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/editing/backspace-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/editing/delete_block_contents.sky View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/tests/editing/delete_block_contents-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/editing/replace.sky View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/tests/editing/replace-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/editing/selection.sky View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/tests/editing/selection-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/editing/typing.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/editing/typing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/events/custom-event.sky View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/tests/events/custom-event-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/events/dispatcher.sky View 1 chunk +0 lines, -103 lines 1 comment Download
D sky/tests/events/dispatcher-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/events/gesture-events.sky View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/tests/events/gesture-events-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/events/pointer-events.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/tests/events/pointer-events-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/harness/reftest.sky View 1 chunk +0 lines, -13 lines 0 comments Download
D sky/tests/harness/reftest-expected.sky View 1 chunk +0 lines, -13 lines 0 comments Download
D sky/tests/harness/reftest-mismatch.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/harness/reftest-mismatch-expected-mismatch.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/http/conf/debian-httpd-2.2.conf View 1 chunk +0 lines, -163 lines 0 comments Download
D sky/tests/http/conf/debian-httpd-2.4.conf View 1 chunk +0 lines, -148 lines 0 comments Download
D sky/tests/http/conf/mime.types View 1 chunk +0 lines, -602 lines 0 comments Download
D sky/tests/http/conf/webkit-httpd.pem View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/layout/borderbox-percent-padding.sky View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/tests/layout/borderbox-percent-padding-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/layout/clipping-elementFromPoint.sky View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/tests/layout/clipping-elementFromPoint-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/layout/custom.sky View 1 chunk +0 lines, -158 lines 0 comments Download
D sky/tests/layout/custom-dirty-bits.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/tests/layout/custom-dirty-bits-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/tests/layout/custom-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/layout/document-elementFromPoint.sky View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/tests/layout/document-elementFromPoint-absolute-position.sky View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/tests/layout/document-elementFromPoint-absolute-position-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/layout/document-elementFromPoint-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/layout/ellipsis.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/tests/layout/ellipsis-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/layout/fixed-width.sky View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/tests/layout/fixed-width-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/layout/margins.sky View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/tests/layout/margins-absolute.sky View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/layout/margins-absolute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/layout/margins-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/layout/position-absolute.sky View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tests/layout/position-absolute-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/layout/position-absolute-pixels.sky View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/tests/layout/position-absolute-pixels-expected.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/lowlevel/abarth.sky View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/tests/lowlevel/abarth-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/tests/lowlevel/bug-438036.sky View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/tests/lowlevel/bug-438036-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/lowlevel/camel-case.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/lowlevel/camel-case-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/lowlevel/classlist.sky View 1 chunk +0 lines, -126 lines 0 comments Download
D sky/tests/lowlevel/classlist-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/lowlevel/createElement.sky View 1 chunk +0 lines, -112 lines 0 comments Download
D sky/tests/lowlevel/createElement-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/lowlevel/document.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/lowlevel/document-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/lowlevel/filters.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/lowlevel/filters-expected.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/lowlevel/hello-world.sky View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/tests/lowlevel/hello-world-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/lowlevel/home.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/lowlevel/home-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/lowlevel/img.sky View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/lowlevel/img-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/lowlevel/layers.sky View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/tests/lowlevel/layers-expected.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/lowlevel/query-selector.sky View 1 chunk +0 lines, -84 lines 0 comments Download
D sky/tests/lowlevel/query-selector-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/lowlevel/style-basic.sky View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tests/lowlevel/style-basic-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/lowlevel/style-specificity.sky View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/tests/lowlevel/style-specificity-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/lowlevel/text.sky View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/lowlevel/text-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/application.sky View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/tests/modules/application-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/modules/basic.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/basic-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/dart-imports-loader-interaction.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/dart-imports-loader-interaction-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/import-syntax-error.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/import-syntax-error-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/import-without-export.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/import-without-export-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/imports-can-import.sky View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/modules/imports-can-import-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/imports-can-load-404s.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/imports-can-load-404s-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tests/modules/instance-of-application.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/modules/instance-of-application-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/instance-of-module.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/modules/instance-of-module-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/load-event.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/tests/modules/load-event-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/modules/modules.sky View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/tests/modules/modules-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/modules/multiple-scripts.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/modules/multiple-scripts-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/multiple-scripts-import.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/modules/multiple-scripts-import-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/modules/resources/dart-import.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/modules/resources/does-not-export.sky View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/modules/resources/instance-of-module-module.sky View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tests/modules/resources/intermediate.sky View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/modules/resources/multiple-scripts-child.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/modules/resources/pass.sky View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tests/modules/resources/syntax-error.sky View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/tests/modules/resources/with-dart-import.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/modules/script-import.sky View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/modules/script-import-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/parser/README.md View 1 chunk +0 lines, -133 lines 0 comments Download
D sky/tests/parser/comments.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/parser/comments-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/parser/control.sky View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/parser/control-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/tests/parser/cr.sky View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/parser/cr-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/parser/empty.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/parser/empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/parser/endtag.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/parser/endtag-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/parser/entity.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/parser/entity-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/parser/html.sky View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/tests/parser/html-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/tests/parser/normaliser-crlf.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/parser/normaliser-crlf-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/tests/parser/normaliser-null.sky View Binary file 0 comments Download
D sky/tests/parser/normaliser-null-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/parser/script.sky View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/tests/parser/script-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/tests/parser/starttag.sky View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/tests/parser/starttag-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/tests/parser/style.sky View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/tests/parser/style-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tests/parser/utf16.sky View Binary file 0 comments Download
D sky/tests/parser/utf16-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/parser/voidtag.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/parser/voidtag-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/parser/whitespace.sky View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/tests/parser/whitespace-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/resources/check-layout.sky View 1 chunk +0 lines, -196 lines 0 comments Download
D sky/tests/resources/dump-as-markup.sky View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/resources/dump-as-render-tree.sky View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/resources/dump-as-text.sky View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/tests/resources/run-after-display.sky View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/tests/services/event-sender.sky View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/tests/services/event-sender-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/services/iframe-embed-vmc.sky View 1 chunk +0 lines, -55 lines 1 comment Download
D sky/tests/services/iframe-embed-vmc-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/services/iframe-service-provider.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/tests/services/iframe-service-provider-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/styles/border-parsing.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/styles/border-parsing-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/styles/transforms.sky View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/tests/styles/transforms-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 19:34:35 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1215063003/diff/1/sky/tests/TestExpectations File sky/tests/TestExpectations (right): https://codereview.chromium.org/1215063003/diff/1/sky/tests/TestExpectations#newcode1 sky/tests/TestExpectations:1: # No test expectations... yet. You should leave ...
5 years, 5 months ago (2015-06-30 19:38:51 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-06-30 19:43:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06fbe04d969b3a31413821612057cb3613693502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698