Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1215053004: pkg/pool: remove usage of Chain.track (Closed)

Created:
5 years, 5 months ago by kevmoo
Modified:
5 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/pool.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove usage of Chain.track The min SDK is already 1.9, so we're not leaving anyone behind Also removed an unused variable in pool_test R=nweiz@google.com Committed: https://github.com/dart-lang/pool/commit/1f2f018a7b3c741deb7fd37111dab1c89011b282

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M lib/pool.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/pool_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 5 months ago (2015-07-01 00:27:29 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1215053004/diff/1/lib/pool.dart File lib/pool.dart (right): https://codereview.chromium.org/1215053004/diff/1/lib/pool.dart#newcode90 lib/pool.dart:90: return request().then((resource) => new Future.sync(callback).whenComplete(resource.release)); Long line. https://codereview.chromium.org/1215053004/diff/1/pubspec.yaml ...
5 years, 5 months ago (2015-07-01 00:44:35 UTC) #3
kevmoo
https://codereview.chromium.org/1215053004/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1215053004/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 1.2.0-dev On 2015/07/01 00:44:35, nweiz wrote: > This ...
5 years, 5 months ago (2015-07-01 00:46:31 UTC) #4
kevmoo
5 years, 5 months ago (2015-07-01 00:46:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1f2f018a7b3c741deb7fd37111dab1c89011b282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698